-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Swift Package Manager Support #1683
Add Swift Package Manager Support #1683
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks okay to me.
I wonder if we should move this to version 8.2.0 instead?
@alejandro-all-win-software fyi: I did a fix-forward for the merge conflict. We landed a MacOS change a few moments ago, so it was giving a small issue with versioning. |
@alejandro-all-win-software Once the branch in the Package.swift is updated, I'll test this locally and then this looks good to release. Thank you! |
@navaronbracke I also updated the macOS implementation to support SPM |
@alejandro-all-win-software While preparing to test this locally, I also saw this in my terminal:
This is for the file_picker example app. Would you like to address this as well? The example app can run on SPM only. |
@alejandro-all-win-software I'll verify locally if this works in XCode (just as a sanity check) and then this is ready for a release. |
Oh, missed that! :D You can close the #1692 in favor of it |
@alejandro-all-win-software This works for both iOS & MacOS, thanks! One thing I'm not sure about, though: When opening the iOS or the MacOS example app in XCode, the |
Let me check. |
Yeah, I see changes when removing them. Let me commit it. |
This should be available on Pub in a moment! |
DESCRIPTION