Ensure label selector matches both filesystem and block labels #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The block server pod had a slightly different label than the filesystem server pod, and this caused the code that waits for the server to be running to not match the pod. This then caused the clients to start while the server was not yet running. This leads to a race condition where the clients can attempt to connect to the server before it is ready to accept the connections. This then leads to tls errors and the transfer failing. Signed-off-by: Alexander Wels <[email protected]>
rayfordj
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block server pod had a slightly different label than the filesystem server pod, and this caused the code that waits for the server to be running to not match the pod. This then caused the clients to start while the server was not yet running. This leads to a race condition where the clients can attempt to
connect to the server before it is ready to accept the connections. This then leads to tls errors and the transfer failing.
Fixed issue with it not printing the correct name in the logs for the secret.