Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: project configuration for releases #806

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix: project configuration for releases #806

merged 1 commit into from
Jul 10, 2024

Conversation

baywet
Copy link
Member

@baywet baywet commented Jul 10, 2024

misshap in #802 conventional commit which won't trigger release please

@baywet baywet self-assigned this Jul 10, 2024
@baywet baywet enabled auto-merge July 10, 2024 14:14
@samwelkanda
Copy link
Contributor

In the pyproject.toml file, module should be:

[tool.flit.module]
name = "msgraph"

msgraph-sdk is not a valid path thus the build will fail

@baywet baywet merged commit a188189 into main Jul 10, 2024
7 checks passed
@baywet baywet deleted the release/onefivetwo branch July 10, 2024 14:40
@baywet baywet mentioned this pull request Jul 10, 2024
Merged
@baywet
Copy link
Member Author

baywet commented Jul 10, 2024

@samwelkanda thanks for pointing this out. see #807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baywet @samwelkanda @andrueastman