Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Requests generated by Microsoft Graph SDKs use the fully qualified name." #2813

Closed
catmanjan opened this issue Jan 28, 2025 · 2 comments
Closed
Labels
Status: No recent activity type:bug A broken experience type:documentation General documentation request or project documentation update

Comments

@catmanjan
Copy link

Describe the bug

I refer to https://learn.microsoft.com/en-us/graph/delta-query-overview

Image

The blurb in green does not appear to be true because when I do trace logging of the request the URL is just .../delta() not .../microsoft.graph.delta()

Expected behavior

Image

How to reproduce

Do a delta request and inspect the URL

SDK Version

No response

Latest version known to work for scenario above?

No response

Known Workarounds

No response

Debug output

Click to expand log ```
</details>


### Configuration

_No response_

### Other information

_No response_
@catmanjan catmanjan added status:waiting-for-triage An issue that is yet to be reviewed or assigned type:bug A broken experience labels Jan 28, 2025
@andrueastman
Copy link
Member

Thanks for raising this @catmanjan,

I believe this is currently a slight misguidance in the documentation.

For context, using the Kiota generator, a path like microsoft.graph.delta on users will result in the generation of the fluent method as graphClient.Users.MicrosoftGraphDelta, to provide a better user experience for the user, we have leveraged this setting in the metadata conversion process to strip out the microsoft.graph prefix in scenarios where this is feasibile in order to result in the end experience looking like graphClient.Users.Delta. Therefore, for it may be true that the SDK will use the fully qualified in some scenarios(essentially actions/functions that are not in the root Microsoft Graph namespace), but the conversion/generation process makes a best attempt to have a better looking fluent API.

Any chance you would you be willing to push a PR to the docs page you linked to help improve that page? (I believe there should be an edit icon on the top right of the page that should be able to help with that)

@andrueastman andrueastman added status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close type:documentation General documentation request or project documentation update and removed status:waiting-for-triage An issue that is yet to be reviewed or assigned labels Jan 29, 2025
catmanjan added a commit to catmanjan/microsoft-graph-docs-contrib that referenced this issue Jan 30, 2025
Copy link
Contributor

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: No recent activity type:bug A broken experience type:documentation General documentation request or project documentation update
Projects
None yet
Development

No branches or pull requests

2 participants