Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow checking statuscodes of batch response without parsing step body #626

Merged

Conversation

svrooij
Copy link
Contributor

@svrooij svrooij commented Mar 15, 2023

Fixes #621

Changes proposed in this pull request

  • Expose GetResponsesStatusCodesAsync() for BatchResponseContentCollection and BatchResponseContent that allows checking the status codes without creating HttpResponseMessage for each step (that has to be disposed)
  • Expose BatchRequestSteps for BatchRequestContentCollection so you can possibly fetch the failed steps to retry, for instance in case of some 429 results in the batch.
  • extra constructor for BatchRequestContentCollection including the number of requests that may be combined. (At the moment you cannot combine more then 4 requests, when creating TodoTasks, all above 4 fail with 429.) This allows the user to use batching without having to manage smaller batches himself.

Other links

@maisarissi I've made batching even better to also support getting the failing steps.

Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this.

@andrueastman andrueastman enabled auto-merge March 15, 2023 14:19
@andrueastman andrueastman merged commit 3815c5c into microsoftgraph:dev Mar 15, 2023
@maisarissi
Copy link

Thanks @svrooij again, for the proposed enhancements!

@svrooij
Copy link
Contributor Author

svrooij commented Mar 17, 2023

@maisarissi does Microsoft also have a digital badge for "brilliant ideas"? And the mean reason for this latest PR was that we are faced with a limit of 4 requests when trying to modify TodoTasks. Where should I post about that issue?

@andrueastman andrueastman mentioned this pull request Mar 20, 2023
@maisarissi
Copy link

Hey @svrooij . I'm not aware of such badge, but we are working on a new program related to SDKs :) Once the program is ready, we will communicate how things are going to work.
For the second question around TodoTasks, this is an API limitation, so I would say the best place to ask questions/features is the Microsoft Q&A: https://developer.microsoft.com/en-us/graph/support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BatchResponseContent and BatchResponseContentCollection should have validate success
3 participants