Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert latest OpenAPI updates #172

Merged
merged 7 commits into from
Jun 27, 2022
Merged

Revert latest OpenAPI updates #172

merged 7 commits into from
Jun 27, 2022

Conversation

zengin
Copy link
Contributor

@zengin zengin commented Jun 27, 2022

This is causing a live site issue because DevX API reads OpenAPI document directly from GitHub for snippet generation. Reverting to last known good state, i.e. last week's update. We will hit this issue again tomorrow when the generation schedule kicks in.

  • Revert "Update clean metadata file with 78287 [skip ci]"
  • Revert "Update clean metadata file with 78287 [skip ci]"
  • Revert "Update clean metadata file with 78287 [skip ci]"
  • Revert "Update clean metadata file with 78287 [skip ci]"
  • Revert "Updated v1.0_metadata.xml"
  • Revert "Updated beta_metadata.xml"
  • Revert "Update clean metadata file with 78286 [skip ci]"

cc: @andrueastman @irvinesunday @baywet to double check if reverting causes any issues for stuff that rely on OpenAPI document. At the moment, parsing of the document seems to be failing.

cc: @nikithauc @rkodev @fey101

@zengin
Copy link
Contributor Author

zengin commented Jun 27, 2022

kiota command mentioned in the original issue works with the OpenAPI document from this branch:

C:\github\kiota\src\kiota\bin\Debug\net6.0\kiota.exe -d https://raw.githubusercontent.com/microsoftgraph/msgraph-metadata/zengin/revert/openapi/v1.0/openapi.yaml --language typescript -o C:\test_typescript -c GraphBaseServiceClient -n MicrosoftGraph

@zengin zengin merged commit b45b696 into master Jun 27, 2022
@baywet baywet deleted the zengin/revert branch June 28, 2022 12:08
@baywet
Copy link
Member

baywet commented Jun 28, 2022

Thanks for the quick revert, I've been root causing this, have updated all the related issues (tactical) and I'll be posting a recap here (strategic)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants