-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update generated code. #247
Conversation
Schema version: microsoftgraph/msgraph-metadata@c042ff7b Generator version: microsoft/kiota@8e21ff5c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a great set of changes, the CLI is most likely going to be much more resiliant. I think the only pattern that we'd probably change is the following
var response = await RequestAdapter.SendPrimitiveAsync<Stream>(requestInfo, errorMapping: errorMapping, cancellationToken: cancellationToken) ?? Stream.Null;
response = (response is not null) ? await outputFilter.FilterOutputAsync(response, query, cancellationToken) : response;
response at the first line will never be null, so the second line will always apply the filter. We might want to compare the reference to stream.null instead or always call the filtering logic if it handles empty streams gracefully
Hey Vincent, I can add a check against |
Schema version: microsoftgraph/msgraph-metadata@e616d5be Generator version: microsoft/kiota@c20f06b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. You're probably impacted by microsoft/kiota#2234 but this is probably an edge case (excel endpoints only) that'll resolve itself whenever it's fixed
I wonder if we should wait on microsoft/kiota#2251 |
Schema version: microsoftgraph/msgraph-metadata@e616d5be Generator version: microsoft/kiota@ed2ce219
Schema version: microsoftgraph/msgraph-metadata@c042ff7b
Generator version: microsoft/kiota@8e21ff5c