Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct admin roles for profile photo edits. #9506

Merged
merged 8 commits into from
Jan 30, 2025

Conversation

mastachon
Copy link
Contributor

@mastachon mastachon commented Jan 30, 2025

New role (People Administrator) was introduced in Entra for profile photo edits, updating the docs with it.
Relevant PR: https://msazure.visualstudio.com/One/_git/AD-MSODS-Core/pullrequest/11640921?path=%2Fsrc%2Fdev%2Fidentity%2Fauthz%2FRoleDefinitions%2FroleDefinitions%2FGlobalAdministrator%2FGlobalAdministrator.json
Following the process in https://eng.ms/docs/microsoft-security/identity/entra-developer-application-platform/app-vertical/aad-first-party-apps/identity-platform-and-access-management/role-based-access-control/ship-new-role.


Important

The following guidance is for Microsoft employees only. Community contributors can ignore this message; our content team will manage the status.

After you've created your PR, expand this section for tips and additional instructions.
  • do not merge is the default PR status and is automatically added to all open PRs that don't have the ready to merge label.
  • Add the ready for content review label to start a review. Only PRs that have met the minimum requirements for content review and have this label are reviewed.
  • If your content reviewer requests changes, review the feedback and address accordingly as soon as possible to keep your pull request moving forward. After you address the feedback, remove the changes requested label, add the review feedback addressed label, and select the Re-request review icon next to the content reviewer's alias. If you can't add labels, add a comment with #feedback-addressed to the pull request.
  • After the content review is complete, your reviewer will add the content review complete label. When the updates in this PR are ready for external customers to use, replace the do not merge label with ready to merge and the PR will be merged within 24 working hours.
  • Pull requests that are inactive for more than 6 weeks will be automatically closed. Before that, you receive reminders at 2 weeks, 4 weeks, and 6 weeks. If you still need the PR, you can reopen or recreate the request.

For more information, see the Content review process summary.

New role was introduced in Entra for profile photo edits, updating the docs with it.
Copy link

Learn Build status updates of commit 9dc88c1:

✅ Validation status: passed

File Status Preview URL Details
api-reference/v1.0/api/profilephoto-update.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit f9714e6:

✅ Validation status: passed

File Status Preview URL Details
api-reference/v1.0/api/profilephoto-delete.md ✅Succeeded
api-reference/v1.0/api/profilephoto-update.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 93b776c:

✅ Validation status: passed

File Status Preview URL Details
api-reference/beta/api/profilephoto-update.md ✅Succeeded
api-reference/v1.0/api/profilephoto-delete.md ✅Succeeded
api-reference/v1.0/api/profilephoto-update.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 8da2b51:

✅ Validation status: passed

File Status Preview URL Details
api-reference/beta/api/profilephoto-delete.md ✅Succeeded
api-reference/beta/api/profilephoto-update.md ✅Succeeded
api-reference/v1.0/api/profilephoto-delete.md ✅Succeeded
api-reference/v1.0/api/profilephoto-update.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit e410b03:

💡 Validation status: suggestions

File Status Preview URL Details
concepts/profilephoto-configure-settings.md 💡Suggestion Details
api-reference/beta/api/profilephoto-delete.md ✅Succeeded
api-reference/beta/api/profilephoto-update.md ✅Succeeded
api-reference/v1.0/api/profilephoto-delete.md ✅Succeeded
api-reference/v1.0/api/profilephoto-update.md ✅Succeeded

concepts/profilephoto-configure-settings.md

  • Line 18, Column 229: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /microsoft-365/enterprise/deploy-identity-solution-identity-model?view=o365-worldwide

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link

Learn Build status updates of commit 464914c:

💡 Validation status: suggestions

File Status Preview URL Details
concepts/profilephoto-configure-settings.md 💡Suggestion Details
api-reference/beta/api/profilephoto-delete.md ✅Succeeded
api-reference/beta/api/profilephoto-update.md ✅Succeeded
api-reference/v1.0/api/profilephoto-delete.md ✅Succeeded
api-reference/v1.0/api/profilephoto-update.md ✅Succeeded

concepts/profilephoto-configure-settings.md

  • Line 18, Column 229: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /microsoft-365/enterprise/deploy-identity-solution-identity-model?view=o365-worldwide

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Danielabom Danielabom self-assigned this Jan 30, 2025
@Danielabom Danielabom added ready for content review PR is ready for a content review - content development and tech review are complete. content review in progress labels Jan 30, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed the ready for content review PR is ready for a content review - content development and tech review are complete. label Jan 30, 2025
Copy link

Learn Build status updates of commit 23842ff:

💡 Validation status: suggestions

File Status Preview URL Details
concepts/profilephoto-configure-settings.md 💡Suggestion Details
api-reference/beta/api/profilephoto-delete.md ✅Succeeded
api-reference/beta/api/profilephoto-update.md ✅Succeeded
api-reference/v1.0/api/profilephoto-delete.md ✅Succeeded
api-reference/v1.0/api/profilephoto-update.md ✅Succeeded

concepts/profilephoto-configure-settings.md

  • Line 18, Column 229: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /microsoft-365/enterprise/deploy-identity-solution-identity-model?view=o365-worldwide

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Danielabom Danielabom added content review complete Apply when the content review is complete on a PR. ready to merge Use this label to indicate to the repository admins that your PR is ready to merge into master. labels Jan 30, 2025
Copy link
Contributor

Thank you for your work in this PR, @mastachon.

When the updates in this PR are ready for external customers to use, please replace the do not merge label with ready to merge.

Check the content review workflow here.

@Danielabom Danielabom merged commit c73f6ce into microsoftgraph:main Jan 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content review complete Apply when the content review is complete on a PR. ready to merge Use this label to indicate to the repository admins that your PR is ready to merge into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants