Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Search schema known limitation for Graph Search API #8785

Merged
merged 8 commits into from
Nov 28, 2023

Conversation

yiwenwang-ms
Copy link
Contributor

No description provided.

Copy link

Learn Build status updates of commit b9ec630:

✅ Validation status: passed

File Status Preview URL Details
api-reference/beta/resources/search-api-overview.md ✅Succeeded
api-reference/v1.0/resources/search-api-overview.md ✅Succeeded
concepts/search-concept-files.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@njerigrevious njerigrevious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but can we make the clarification a bit clearer on what schema is supported for managd properties?

@@ -205,6 +205,8 @@ The search API has the following limitations:

- Customizations in SharePoint search, such as a custom search schema or result sources, can interfere with Microsoft Search API operations.

- Graph Search API doesn't support site-level [search schema](/sharepoint/manage-search-schema)
Copy link
Contributor

@njerigrevious njerigrevious Nov 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this clearer to say "Graph Search API doesn't support site-level search schema, only tenant-level and out-of-the-box (OOTB)"?

@@ -221,6 +221,8 @@ The search API has the following limitations:

- Customizations in SharePoint search, such as a custom search schema or result sources, can interfere with Microsoft Search API operations.

- Graph Search API doesn't support site-level [search schema](/sharepoint/manage-search-schema)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Global: Please revise the text as follows:

The search API doesn't support the site-level search schema.

Copy link

Learn Build status updates of commit 519f3a4:

✅ Validation status: passed

File Status Preview URL Details
api-reference/beta/resources/search-api-overview.md ✅Succeeded
api-reference/v1.0/resources/search-api-overview.md ✅Succeeded
concepts/search-concept-files.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 2069b85:

✅ Validation status: passed

File Status Preview URL Details
api-reference/beta/resources/search-api-overview.md ✅Succeeded
api-reference/v1.0/resources/search-api-overview.md ✅Succeeded
concepts/search-concept-files.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@njerigrevious njerigrevious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - thank you!

@Lauragra Lauragra added the ready to merge Use this label to indicate to the repository admins that your PR is ready to merge into master. label Nov 28, 2023
Copy link

Learn Build status updates of commit e56d2bb:

✅ Validation status: passed

File Status Preview URL Details
api-reference/beta/resources/search-api-overview.md ✅Succeeded
api-reference/v1.0/resources/search-api-overview.md ✅Succeeded
concepts/search-concept-files.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 51855c7:

✅ Validation status: passed

File Status Preview URL Details
api-reference/beta/resources/search-api-overview.md ✅Succeeded
api-reference/v1.0/resources/search-api-overview.md ✅Succeeded
concepts/search-concept-files.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Lauragra Lauragra merged commit eb3ff23 into microsoftgraph:main Nov 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Use this label to indicate to the repository admins that your PR is ready to merge into master. review feedback addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants