Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Flakron.ApacheMaven version 3.8.9 #163496

Conversation

flakron
Copy link

@flakron flakron commented Jul 17, 2024

The installer for the package, is built in this repo: https://github.com/flakron/winget-apache-maven

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change? - There is one, but it is stale.
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@flakron
Copy link
Author

flakron commented Jul 17, 2024

@microsoft-github-policy-service agree [company="Flakron Bytyqi"]

@flakron
Copy link
Author

flakron commented Jul 17, 2024

@microsoft-github-policy-service agree

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-No-Executables labels Jul 18, 2024
Copy link
Collaborator

@stephengillie stephengillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @flakron,

  • This appears to be the same package as another PR - should the same PackageIdentifier be used?
  • This package appears to be a Java application.
    image
  • This means both that:
    • A JRE is a dependency
    • Unfortunately we're not currently accepting scripted (non-compiled) applications.

@stephengillie stephengillie added portable-jar Portable JAR that needs JRE/JDK and to not be renamed. Scripted-Application This package appears to be a PS1, BAT, or other scripted (not-compiled) application. and removed Changes-Requested Changes Requested labels Jul 18, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jul 18, 2024
@stephengillie stephengillie added the Changes-Requested Changes Requested label Jul 18, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jul 18, 2024
@flakron
Copy link
Author

flakron commented Jul 18, 2024

Hi @stephengillie

  • I didn't see where any specific rule in regards to naming the PackageIdentifier, But to the point, since Maven is maintained by the Apache Foundation, and I'm not affiliated with them it didn't seem to me right to pretend that the package is built by them, and it seemed a bit disingenuous.
  • The package is a dependency manager for java development. It is dependent on jdk not jre, JAVA_HOME is referred to the jdk install directory (whatever jdk the user is using).
  • Unfortunately they will never have a executable binary. So maybe I close the pull request altogether, if the guidelines do not accept such cases (unfortunately since a lot of Java tools will never have binary executables).

@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jul 19, 2024
@flakron flakron closed this Jul 19, 2024
@flakron flakron deleted the Flakron.ApacheMaven-3.8.9-ce4b052e-d53e-499f-a3b7-c46e22313487 branch July 19, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Changes-Requested Changes Requested New-Package portable-jar Portable JAR that needs JRE/JDK and to not be renamed. Scripted-Application This package appears to be a PS1, BAT, or other scripted (not-compiled) application. Validation-No-Executables
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants