-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: Flakron.ApacheMaven version 3.8.9 #163496
Closed
flakron
wants to merge
1
commit into
microsoft:master
from
flakron:Flakron.ApacheMaven-3.8.9-ce4b052e-d53e-499f-a3b7-c46e22313487
Closed
New package: Flakron.ApacheMaven version 3.8.9 #163496
flakron
wants to merge
1
commit into
microsoft:master
from
flakron:Flakron.ApacheMaven-3.8.9-ce4b052e-d53e-499f-a3b7-c46e22313487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
@microsoft-github-policy-service agree [company="Flakron Bytyqi"] |
@microsoft-github-policy-service agree |
stephengillie
requested changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @flakron,
- This appears to be the same package as another PR - should the same
PackageIdentifier
be used? - This package appears to be a Java application.
- This means both that:
- A
JRE
is a dependency - Unfortunately we're not currently accepting scripted (non-compiled) applications.
- A
manifests/f/Flakron/ApacheMaven/3.8.9/Flakron.ApacheMaven.installer.yaml
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Azure-Pipeline-Passed
Validation pipeline passed. There may still be manual validation requirements.
Changes-Requested
Changes Requested
New-Package
portable-jar
Portable JAR that needs JRE/JDK and to not be renamed.
Scripted-Application
This package appears to be a PS1, BAT, or other scripted (not-compiled) application.
Validation-No-Executables
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installer for the package, is built in this repo: https://github.com/flakron/winget-apache-maven
Checklist for Pull Requests
Manifests
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the directory's name containing the manifest you're submitting.Microsoft Reviewers: Open in CodeFlow