Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify: Spotify.Spotify version 1.2.38.720.ga4a70a0e #155308

Conversation

aisgbnok
Copy link
Contributor

@aisgbnok aisgbnok commented May 27, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label May 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 27, 2024
@aisgbnok aisgbnok force-pushed the update-Spotify.Spotify-1.2.38.720.ga4a70a0e branch from 56c016b to 910cce4 Compare May 27, 2024 15:16
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Author-Feedback This needs a response from the author. Validation-Installation-Error Error installing application labels May 27, 2024
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels May 27, 2024
@aisgbnok
Copy link
Contributor Author

aisgbnok commented May 27, 2024

Root

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed

https://dev.azure.com/ms/winget-pkgs/_build/results?buildId=575615

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels May 27, 2024
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label May 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 27, 2024
@aisgbnok
Copy link
Contributor Author

Individual Installer Nodes

Installers:
- Architecture: x64
InstallerUrl: https://upgrade.scdn.co/upgrade/client/win32-x86_64/spotify_installer-1.2.38.720.ga4a70a0e-1223.exe
InstallerSha256: 08E3EBDF619C4AA97BF861A6F42097B1948EBBD12D6D1848C6C67D2B717429D5
ElevationRequirement: elevationProhibited
- Architecture: x86
InstallerUrl: https://upgrade.scdn.co/upgrade/client/win32-x86/spotify_installer-1.2.38.720.ga4a70a0e-1222.exe
InstallerSha256: D3AE4895DEE3FCB82782BBB6CE5E620CB664C9656B3D549A81E9E0008C0E565B
ElevationRequirement: elevationProhibited
- Architecture: arm64
InstallerUrl: https://upgrade.scdn.co/upgrade/client/win32-arm64/spotify_installer-1.2.38.720.ga4a70a0e-1223.exe
InstallerSha256: A2132BEBBE744CBD287242858AFEC99B800F41DCC2BA7815BD6B735972A1435F
ElevationRequirement: elevationProhibited

Validation-Installation-Error Error installing application

https://dev.azure.com/ms/winget-pkgs/_build/results?buildId=575625

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 27, 2024
@aisgbnok
Copy link
Contributor Author

aisgbnok commented May 27, 2024

Why does 910cce4 pass validation (comment), but 84484dc fail validation (comment)? The only difference being ElevationRequirement: elevationProhibited in the YAML root (pass) vs individual installer nodes (fail)?

This is related to #154823, and doesn't seem to be an issue with the installer. It may be WinGet or validation?

@aisgbnok aisgbnok marked this pull request as ready for review May 27, 2024 19:16
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978335146

Automated error analysis suggests -1978335146 may mean The installer cannot be run from an administrator context - does this package require ElevationRequirement: elevationProhibited?

(Automated response - build 881.)

- Architecture: x64
InstallerUrl: https://upgrade.scdn.co/upgrade/client/win32-x86_64/spotify_installer-1.2.38.720.ga4a70a0e-1223.exe
InstallerSha256: 08E3EBDF619C4AA97BF861A6F42097B1948EBBD12D6D1848C6C67D2B717429D5
ProductCode: Spotify
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing the ProductCode? 🤔

@denelon
Copy link
Contributor

denelon commented May 29, 2024

@aisgbnok, I didn't see a bug filed anywhere related to the location of the "ElevationRequirement" in the manifest other than one related to install modes. Feel free to file a bug if you believe it's an improper behavior in the client over at winget-cli, but if you believe it's isolated to the validation environment, it should be filed here.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Sep 7, 2024
@ItzLevvie
Copy link
Contributor

Close with reason: See above;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Installation-Error Error installing application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants