-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify: Spotify.Spotify version 1.2.38.720.ga4a70a0e #155308
Modify: Spotify.Spotify version 1.2.38.720.ga4a70a0e #155308
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
56c016b
to
910cce4
Compare
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Rootwinget-pkgs/manifests/s/Spotify/Spotify/1.2.38.720.ga4a70a0e/Spotify.Spotify.installer.yaml Line 15 in 910cce4
Azure-Pipeline-Passed
https://dev.azure.com/ms/winget-pkgs/_build/results?buildId=575615 |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Individual Installer Nodeswinget-pkgs/manifests/s/Spotify/Spotify/1.2.38.720.ga4a70a0e/Spotify.Spotify.installer.yaml Lines 15 to 27 in 84484dc
Validation-Installation-Error
https://dev.azure.com/ms/winget-pkgs/_build/results?buildId=575625 |
Why does 910cce4 pass validation (comment), but 84484dc fail validation (comment)? The only difference being This is related to #154823, and doesn't seem to be an issue with the installer. It may be WinGet or validation? |
Automatic Validation ended with:
Automated error analysis suggests -1978335146 may mean The installer cannot be run from an administrator context - does this package require (Automated response - build 881.) |
- Architecture: x64 | ||
InstallerUrl: https://upgrade.scdn.co/upgrade/client/win32-x86_64/spotify_installer-1.2.38.720.ga4a70a0e-1223.exe | ||
InstallerSha256: 08E3EBDF619C4AA97BF861A6F42097B1948EBBD12D6D1848C6C67D2B717429D5 | ||
ProductCode: Spotify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you removing the ProductCode
? 🤔
@aisgbnok, I didn't see a bug filed anywhere related to the location of the "ElevationRequirement" in the manifest other than one related to install modes. Feel free to file a bug if you believe it's an improper behavior in the client over at winget-cli, but if you believe it's isolated to the validation environment, it should be filed here. |
Close with reason: See above; |
Checklist for Pull Requests
Manifests
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the name of the directory containing the manifest you're submitting.Microsoft Reviewers: Open in CodeFlow