Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version: OpenJS.NodeJS.Nightly version 21.0.0-nightly20230703acf071e9d5 #111148

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Add version: OpenJS.NodeJS.Nightly version 21.0.0-nightly20230703acf071e9d5 #111148

merged 3 commits into from
Jul 5, 2023
+81 −0

Conversation

CoolPlayLin
Copy link
Contributor

@CoolPlayLin CoolPlayLin commented Jul 3, 2023 •
edited by microsoft-github-policy-service bot
Loading

Pull request has been created with Komac v1.8.0 🚀

Microsoft Reviewers: codeflow:open?pullrequest=#111148

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service
Copy link
Contributor

CoolPlayLin,

During validation one or more entries for "AppsAndFeatures" did not match what was detected during validation. Please make the appropriate changes to the manifest.

Template: msftbot/validationError/manifest/arpEntries

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jul 3, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Manifest-AppsAndFeaturesVersion-Error labels Jul 3, 2023
@wingetbot wingetbot added the URL-Validation-Error Microsoft Defender SmartScreen triggered during automatic validation label Jul 3, 2023
@wingetbot
Copy link
Collaborator

Url validation error

@microsoft-github-policy-service
Copy link
Contributor

Hello @CoolPlayLin,

The package manager bot determined there was an issue with some of the URLs included in the manifest file. Please check the pull request for more details and make sure the urls are correct.

Template: msftbot/validationError/urls/smartScreen

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jul 3, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the URL-Validation-Error Microsoft Defender SmartScreen triggered during automatic validation label Jul 3, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Jul 3, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jul 3, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) July 3, 2023 09:34
@microsoft-github-policy-service
Copy link
Contributor

CoolPlayLin,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@CoolPlayLin
Copy link
Contributor Author

CoolPlayLin commented Jul 3, 2023 •
edited
Loading

PS

Please making sure following issues have been resolved, before you merge or approve this PR

@CoolPlayLin CoolPlayLin mentioned this pull request Jul 4, 2023
Merged
6 tasks
@stephengillie stephengillie added Blocking-Issue Manifest validation is blocked by a known issue. and removed Blocking-Issue Manifest validation is blocked by a known issue. labels Jul 4, 2023
This was referenced Jul 5, 2023
Merged
Merged
@CoolPlayLin
Copy link
Contributor Author

@jedieaston

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit a835ebd into microsoft:master Jul 5, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 5, 2023
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@CoolPlayLin CoolPlayLin deleted the OpenJS.NodeJS.Nightly-21.0.0-nightly20230703acf071e9d5-21135F8E76A8AD6705A9AFD80DFF514123063C86 branch July 6, 2023 02:55
@lutzroeder lutzroeder mentioned this pull request Jul 7, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CoolPlayLin @wingetbot @stephengillie @yao-msft