Simplify use of unscoped enums #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-weis
reviewed
Jun 8, 2021
| @@ -1,5 +1,5 @@ | |||
| fn main() { | |||
| windows::build! { | |||
| Windows::Win32::UI::WindowsAndMessaging::{MessageBoxA, MB_OK} | |||
| Windows::Win32::UI::WindowsAndMessaging::{MessageBoxA} | |||
There was a problem hiding this comment.
Shouldn't #828 have collapsed that into Windows::Win32::UI::WindowsAndMessaging::MessageBoxA, observed a non-empty git diff, and failed the CI?
There was a problem hiding this comment.
@tim-weis This is only a single use-statement. #828 turns that into:
use format_build_macro::{
Windows::Win32::UI::WindowsAndMessaging::{MessageBoxA}
};Which is then formatted to:
use format_build_macro::Windows::Win32::UI::WindowsAndMessaging::MessageBoxA;The original use format_build_macro::{ pattern is now gone (missing trailing curly brace) meaning we cannot easily go back to windows::build! {. I'll be testing some ideas locally to deal with these files locally, and submit the cleanup for these cases (of which there seem to be quite a few) later.
This was referenced Jun 18, 2021
This was referenced Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #831
A few things to note about this change. Build macros are generally less cluttered as only the enum type needs to be mentioned (not individual constants). Generated bindings are generally longer but large numbers of constants has a minimal effect on build time (thus worthwhile tradeoff for usability).
cc @roblabla