Add weak reference (consumer) support #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
reviewed
Apr 22, 2021
| assert_eq!(result.is_err(), true); | ||
|
|
||
| // E_NOINTERFACE is returned because IWeakReferenceSource is not implemented. | ||
| assert_eq!(result.unwrap_err().code(), HRESULT(0x8000_4002)); |
There was a problem hiding this comment.
Out of curiosity, is there a reason we still don’t define constants for common HRESULTs?
There was a problem hiding this comment.
These are defined in the Win32 metadata. We need to be careful not to depend on these as part of code gen to avoid forcing the consuming apps to require the same dependency. In this particular case, its just a local test so we could rely on generated HRESULTs here.
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the way to #81, first up is support for weak references as this is required for Xaml/WinUI and is just generally what COM and WinRT objects should provide by default. This update adds support for creating a weak reference to an existing implementation. This is the easy part. Next up is implementing weak references as part of the
implementmacro. That's the hard part...