Reintroduce Ref lifetime type parameter
#3448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that C++ delegates use
RefandOutRefto properly handle lifetime and ownership for callbacks (#3447), it became evident thatRefreally should have a lifetime type parameter (#3433). Otherwise its impossible to safely construct aRefon the call side. This does however mean thatRefcan't be used as a type alias inside a trait (#3435) but since this was only being used for WinRT generics, it seems reasonable to favor makingRefsafer over generic code that very few will encounter.