Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't push logs from Publish, we have none. #4364

Merged
merged 6 commits into from
Apr 5, 2023
Merged

Don't push logs from Publish, we have none. #4364

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0e3d1fd
Don't push logs from Publish, we have none.
nohwnd Apr 4, 2023
dedb263
Fix publish warning
nohwnd Apr 5, 2023
978be3a
Name is string
nohwnd Apr 5, 2023
ffd5f65
underscores
nohwnd Apr 5, 2023
00fcc72
New file
nohwnd Apr 5, 2023
1fc9028
no s
nohwnd Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 28 additions & 33 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,39 +221,34 @@ stages:
ArtifactName: TestResults
condition: failed()

- job: Publish
dependsOn: OtherOSes
pool:
${{ if eq(variables._RunAsPublic, True) }}:
name: NetCore-Public
demands: ImageOverride -equals windows.vs2022.amd64.open
${{ if eq(variables._RunAsInternal, True) }}:
name: NetCore1ESPool-Internal
demands: ImageOverride -equals 1es-windows-2022
strategy:
matrix:
Release:
_BuildConfig: Release
# ${{ if eq(variables._RunAsPublic, True) }}:
# Debug:
# _BuildConfig: Debug
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For another PR - Keeping the debug build is interesting and would avoid to have all the Debug.Assert failures uncaught in CI.

steps:
# Download the built packages into local package source, as if we built them on this machine.
- task: DownloadPipelineArtifact@2
displayName: Download Package Artifacts
inputs:
artifactName: PackageArtifacts
targetPath: '$(Build.SourcesDirectory)/artifacts/packages/$(_BuildConfig)/Shipping'

- task: DownloadPipelineArtifact@2
displayName: Download VSSetup Artifacts
inputs:
artifactName: VSSetupArtifacts
targetPath: '$(Build.SourcesDirectory)/artifacts/VSSetup/$(_BuildConfig)'

# TODO: Publishing to the feeds is making non-arcade CI acceptance tests fail so we disable these steps for now.
# They will need to be re-enabled once this is merged to main.
- ${{ if eq(variables._RunAsInternal, True) }}:
- ${{ if eq(variables._RunAsInternal, True) }}:
- job: Publish
dependsOn: OtherOSes
pool:
name: NetCore1ESPool-Internal
demands: ImageOverride -equals 1es-windows-2022
strategy:
matrix:
Release:
_BuildConfig: Release
steps:
# The template job needs a log, otherwise it writes a warning. We can disable log uploading only for
# the whole stage, which is not what we want to do. So we write an empty file instead.
- pwsh: 'New-Item -Type file -Force "$(Build.SourcesDirectory)/artifacts/log/$(_BuildConfig)/empty.log"'
name: 'Add_empty_logfile'
# Download the built packages into local package source, as if we built them on this machine.
- task: DownloadPipelineArtifact@2
displayName: Download Package Artifacts
inputs:
artifactName: PackageArtifacts
targetPath: '$(Build.SourcesDirectory)/artifacts/packages/$(_BuildConfig)/Shipping'

- task: DownloadPipelineArtifact@2
displayName: Download VSSetup Artifacts
inputs:
artifactName: VSSetupArtifacts
targetPath: '$(Build.SourcesDirectory)/artifacts/VSSetup/$(_BuildConfig)'

- task: NuGetAuthenticate@0
displayName: 'NuGet Authenticate to dotnet-tools and test-tools feeds'

Expand Down