Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed dotnet resolution for in-process vstest.console scenarios #4122

Merged
merged 4 commits into from
Nov 22, 2022
Merged

Fixed dotnet resolution for in-process vstest.console scenarios #4122

merged 4 commits into from
Nov 22, 2022

Conversation

cvpoienaru
Copy link
Member

Fixed dotnet resolution for in-process vstest.console scenarios

MarcoRossignoli
MarcoRossignoli reviewed Nov 16, 2022
View reviewed changes
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and pls add one test for every single case and the expected combined one we're using.

src/Microsoft.TestPlatform.CoreUtilities/Helpers/DotnetMuxerResolution.cs Outdated Show resolved Hide resolved
src/Microsoft.TestPlatform.CoreUtilities/Helpers/DotnetMuxerResolution.cs Outdated Show resolved Hide resolved
src/Microsoft.TestPlatform.CoreUtilities/Helpers/DotnetMuxerResolution.cs Outdated Show resolved Hide resolved
src/Microsoft.TestPlatform.CoreUtilities/Helpers/DotnetMuxerResolution.cs Outdated Show resolved Hide resolved
src/Microsoft.TestPlatform.CoreUtilities/Helpers/DotnetHostHelper.cs Outdated Show resolved Hide resolved
src/Microsoft.TestPlatform.TestHostProvider/Hosting/DotnetTestHostManager.cs Outdated Show resolved Hide resolved
src/Microsoft.TestPlatform.TestHostProvider/Hosting/DotnetTestHostManager.cs Outdated Show resolved Hide resolved
MarcoRossignoli
MarcoRossignoli reviewed Nov 22, 2022
View reviewed changes
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add one more that where we test all the strategy one by one and we assert that every step returns the correct information?

@cvpoienaru cvpoienaru merged commit f098763 into microsoft:main Nov 22, 2022
@cvpoienaru cvpoienaru mentioned this pull request Nov 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoRossignoli MarcoRossignoli MarcoRossignoli approved these changes

@nohwnd nohwnd Awaiting requested review from nohwnd nohwnd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cvpoienaru @MarcoRossignoli