Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find vstest.console.dll from the same directory where Microsoft.TestPlatform.targets reside #342

Merged
merged 3 commits into from
Jan 19, 2017

Conversation

Faizan2304
Copy link
Contributor

@Faizan2304 Faizan2304 commented Jan 18, 2017

Issue: dotnet test is failing because the it is not able to find vstest.console.dll. The reason why it is not able to find vstest.console.dll is that we are passing VSTestConsolePath ( whose current value is "vatest.console.dll") to VSTestTask which uses it as it is to create a processThis process Current working is the directory from where we are running test, hence it is not able to resolve vstets.console.dll.

Fix: Find full path of vstest.console.dll and pass it to VSTestTask.

Test Plan:

  1. Manually validated the scenario by replacing Microsoft.TestPlatform.targets and Micrsosoft.Testplatform.build.dll
  2. Manually enable trace log and verified that right path is getting pass to VstestTask.

Copy link
Contributor

@singhsarab singhsarab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the test plan please.

@Faizan2304
Copy link
Contributor Author

Test plan is in summary.

@Faizan2304
Copy link
Contributor Author

@piotrpMSFT : Our assumption here is that Microsoft.TestPlatform.targets and vstest.console.dll is going to be in same directory.

If that is not correct then we can pass the property "VSTestConsolePath" from dotnet test. In this case we calculate VSTestConsolePath=(Path of dotnet.dll)+vstest.console.dll.

Any thoughts here will be welcome.

@Faizan2304 Faizan2304 closed this Jan 18, 2017
@Faizan2304 Faizan2304 reopened this Jan 18, 2017
@codito codito merged commit 0202a8b into microsoft:master Jan 19, 2017
@codito codito deleted the vstestpath branch January 19, 2017 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants