Add option for timeout and custom procdump #2976
Conversation
| @@ -163,6 +163,10 @@ This test may, or may not be the source of the crash.</value> | |||
| <data name="Seconds" xml:space="preserve"> | |||
| <value>seconds</value> | |||
| </data> | |||
| <data name="Terminatin" xml:space="preserve"> | |||
There was a problem hiding this comment.
Seems unused so far. Also, the resource key is using ing but the description is using ed we may want to synchronize that.
src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyOperationManager.cs
Outdated
Show resolved
Hide resolved
| @@ -320,8 +322,10 @@ public virtual void Close() | |||
| finally | |||
| { | |||
| this.initialized = false; | |||
|
|
|||
| EqtTrace.Warning("ProxyOperationManager: Timed out waiting for test host to exit. Will terminate process."); | |||
| if (testHostExitedWithinTimeout == false) | |||
There was a problem hiding this comment.
| if (testHostExitedWithinTimeout == false) | |
| if (!testHostExitedWithinTimeout) |
but I like it if it's done on purpose so feel free to keep as-is
There was a problem hiding this comment.
The variable is nullable so you cannot simply use not.
| this.RequestSender.EndSession(); | ||
|
|
||
| // We want to give test host a chance to safely close. | ||
| // The upper bound for wait should be 100ms. | ||
| var timeout = 100; | ||
| var timeout = int.TryParse(Environment.GetEnvironmentVariable("VSTEST_TESTHOST_TIMEOUT"), out var t) ? t : 100; |
There was a problem hiding this comment.
Variable was already created before but could we rename it into shutdownTimeoutInMs?
| @@ -320,8 +322,10 @@ public virtual void Close() | |||
| finally | |||
| { | |||
| this.initialized = false; | |||
|
|
|||
| EqtTrace.Warning("ProxyOperationManager: Timed out waiting for test host to exit. Will terminate process."); | |||
| if (testHostExitedWithinTimeout == false) | |||
There was a problem hiding this comment.
The variable is nullable so you cannot simply use not.
| @@ -163,6 +163,10 @@ This test may, or may not be the source of the crash.</value> | |||
| <data name="Seconds" xml:space="preserve"> | |||
| <value>seconds</value> | |||
| </data> | |||
| <data name="Terminatin" xml:space="preserve"> | |||
There was a problem hiding this comment.
Seems unused so far. Also, the resource key is using ing but the description is using ed we may want to synchronize that.
|
@nohwnd Is there anything specific you want to test/handle before turning this into mergeable PR? |
|
|
# Conflicts: # src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyOperationManager.cs # src/Microsoft.TestPlatform.Extensions.BlameDataCollector/ProcDumpArgsBuilder.cs
|
Closed in favor of #3466 |
DO NOT MERGE, this is for experiments only
Description
VSTEST_TESTHOST_TIMEOUT to set how many ms we will wait till killing testhost
VSTEST_DUMP_PROCDUMPARGS to provide custom procdump parameters
Related issue
Kindly link any related issues. E.g. Fixes #xyz.