Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eqt trace error was thrown if extension uri is not given #2264

Merged
merged 3 commits into from
Dec 11, 2019
Merged

Eqt trace error was thrown if extension uri is not given #2264

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a96095d
eqttrace error was thrown if extension uri is not given
Dec 4, 2019
ef7b309
check for eqttrace error is enable or not
Dec 10, 2019
d81f910
formatted
Dec 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...rosoft.TestPlatform.Common/ExtensionFramework/Utilities/TestExtensionPluginInformation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,11 @@ private static string GetExtensionUri(Type testLoggerType)
}
}

if(string.IsNullOrEmpty(extensionUri))
{
EqtTrace.Error("Error!! The type \"{0}\" defined in \"{1}\" does not have ExtensionUri attibute.", testLoggerType.ToString(), testLoggerType.Module.Name);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Error!!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EqtTrace check if it is enabled.
Because you calling ToString(), and you can avoid that by checking the condition

}

return extensionUri;
}
}
Expand Down