Set anycpu arch for non dotnet test sources #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
smadala
commented
Oct 26, 2017
smadala
commented
- Settings DefaultPlatform for js, appx or other test source causing warning message showing up if /platform specify not not default platform.
codito
approved these changes
Oct 27, 2017
| @@ -44,8 +44,8 @@ public Architecture AutoDetectArchitecture(List<string> sources, IDictionary<str | |||
| } | |||
| else | |||
| { | |||
| //TODO what to do for js, appx and others? Using default for now. | |||
| arch = Constants.DefaultPlatform; | |||
| //TODO what to do for js, appx and others? Using AnyCPU for now. | |||
There was a problem hiding this comment.
We should remove TODO please.
There was a problem hiding this comment.
Should we make the chutzpah tests in our acceptance suite fail with issues like this? Seems like warnings are a P0 scenario blocker.
There was a problem hiding this comment.
Validate nodejs, python, chutzpah, uwp with this change.
|
It would be good if we can document the behavior for Auto-Detection of Target Platfrom and Target Framework. |
harshjain2
approved these changes
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.