Fix for changes in XPathNavigator for netcoreapp2.0 #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codito
reviewed
Oct 26, 2017
| @@ -20,6 +20,11 @@ | |||
| <Reference Include="Microsoft.CSharp" /> | |||
| <Reference Include="System.Xml" /> | |||
| </ItemGroup> | |||
| <ItemGroup Condition=" '$(TargetFramework)' == 'netstandard1.4' "> | |||
There was a problem hiding this comment.
Not ideal :-/ This will require all the nuget packages to declare an extra dependency.
codito
reviewed
Oct 26, 2017
| return doc; | ||
| #else | ||
| return doc.ToXPathNavigable(); | ||
| var ret = doc as IXPathNavigable; |
There was a problem hiding this comment.
Since this fix applies only to !NET451, could we move the fix accordingly. E.g.
#if NET451
return doc;
#else
var ret = doc as IXPathNavigable;
if ...
#endif
Please add a comment on why line 212 works for netcoreapp2.0. Can we link to the bug also?
codito
approved these changes
Oct 26, 2017
smadala
reviewed
Oct 26, 2017
| @@ -236,38 +236,37 @@ public void UpdateRunSettingsShouldThrowIfArchitectureSetIsIncompatibleWithCurre | |||
| [DataTestMethod] | |||
| [DataRow("DesignMode")] | |||
| [DataRow("CollectSourceInformation")] | |||
| public void UpdateRunSettingsShouldNotModifyXmlIfNavigatorIsNotAtRootNode(string settingName) | |||
| [Ignore] | |||
| public void UpdateRunSettingsShouldNotModifyXmlIfxmlDocumentIsNotAtRootNode(string settingName) | |||
There was a problem hiding this comment.
It is no more required.
We are using xmldoc and therefore, there is no concept of positioning as it used to be in xpathnavigatoor
There was a problem hiding this comment.
Got it, Please remove this test.
smadala
approved these changes
Oct 26, 2017
| @@ -236,38 +236,37 @@ public void UpdateRunSettingsShouldThrowIfArchitectureSetIsIncompatibleWithCurre | |||
| [DataTestMethod] | |||
| [DataRow("DesignMode")] | |||
| [DataRow("CollectSourceInformation")] | |||
| public void UpdateRunSettingsShouldNotModifyXmlIfNavigatorIsNotAtRootNode(string settingName) | |||
| [Ignore] | |||
| public void UpdateRunSettingsShouldNotModifyXmlIfxmlDocumentIsNotAtRootNode(string settingName) | |||
There was a problem hiding this comment.
Got it, Please remove this test.
codito
pushed a commit
to codito/vstest
that referenced
this pull request
Oct 27, 2017
* Fix for changes in XPathNavigator in netcoreapp2.0 * Removed IXPathNavigable.
Merged
smadala
pushed a commit
that referenced
this pull request
Oct 30, 2017
* Object Model Api fix (#1231) * Adding the missing property LocalExtensionData in TestCase * Fixed the test. * Do not crash data collector if a extension initialize fails. (#1230) * Do not crash data collector if a extension initialize fails. * Add unit tests for the scenario. * Fix for changes in XPathNavigator for netcoreapp2.0 (#1226) * Fix for changes in XPathNavigator in netcoreapp2.0 * Removed IXPathNavigable. * Use TPv2 as default for .NET 3.5. (#1232) * Loading native dll's correctly for UWP release mode (#1234) * Loading native dll's correctly for UWP release mode * nit's * decouple process bitness with OS Architecture * HardCoded version of CLI to 2.1.0-preview1-007372 (#1238) HardCoded version of CLI to 2.1.0-preview1-007372 as the latest version has some issues. Reverted to old version of CLI because of dotnet/cli#7921 * Added null check for parent node. * Added conditional statements to support building against netcoreapp1.0 * Get OSArchitecture from Platform Abstraction to check for ARM Processor (#1242) * GetOsArchitecture from Platform Abstraction to check for ARM * making sure path is always small
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for changes in XPathNavigator for netcoreapp2.0.
Issue: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/VS.in%20Agile%20Testing%20IDE/_workitems/edit/491724