Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet test --diag somefile fails (without .txt extension on filename) #3045

Closed
AArnott opened this issue Sep 9, 2021 · 1 comment · Fixed by #3048
Closed

dotnet test --diag somefile fails (without .txt extension on filename) #3045

AArnott opened this issue Sep 9, 2021 · 1 comment · Fixed by #3048
Assignees
@nohwnd
Labels
triaged

Comments

@AArnott
Copy link
Member

AArnott commented Sep 9, 2021

Description

The dotnet test command fails when given a diagnostic file path that does not use .txt as a file extension.

The --help documentation on the command simply says:

-d, --diag <LOG_FILE> Enable verbose logging to the specified file.

So I expect that -d somefile should work.

Steps to reproduce

Run any test with the dotnet test -d somefile command (literally call it somefile -- don't change it to somefile.txt).

Expected behavior

The test runs and somefile contains diagnostic logs.

Actual behavior

The test runner fails with this error:

Diag file path 'C:\git\VS.RPC.Contracts\somefile' is not valid.

Diagnostic logs

LOL. No diag log available. That's the bug.

Environment

.NET SDK v5.0.400
Windows 10
@AArnott
Copy link
Member Author

AArnott commented Sep 9, 2021

My primary concern is discoverability of this. The docs don't state this requirement and the error message doesn't explain the problem either.

@nohwnd nohwnd self-assigned this Sep 9, 2021
@Haplois Haplois added the triaged label Sep 9, 2021
nohwnd added a commit to nohwnd/vstest that referenced this issue Sep 10, 2021
@nohwnd
--diag should take files with no extension
57569b3 
Files with no extension are totally valid files, even though they are unusual on Windows

Fix microsoft#3045
nohwnd added a commit to nohwnd/vstest that referenced this issue Sep 10, 2021
@nohwnd
--diag should take files with no extension
7e0439e 
Files with no extension are totally valid files, even though they are unusual on Windows

Fix microsoft#3045
@nohwnd nohwnd mentioned this issue Sep 10, 2021
Merged
nohwnd added a commit that referenced this issue Sep 10, 2021
@nohwnd
--diag should take files with no extension (#3048)
30345de 
Files with no extension are totally valid files, even though they are unusual on Windows

Fix #3045
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nohwnd nohwnd

Labels
triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

--diag should take files with no extension nohwnd/vstest
3 participants
@AArnott @Haplois @nohwnd