-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update extensionPaths when web extension host started #193849
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please let me know if you need help reproducing this bug |
… applies an extension delta
alexdima
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
bhavyaus
approved these changes
Mar 15, 2024
chen-ky
pushed a commit
to chen-ky/vscode
that referenced
this pull request
Mar 18, 2024
* Invalidate and update extensionPaths on load * Also update the `ExtensionPaths` search tree after startup because it applies an extension delta * Cache realpath calls --------- Co-authored-by: Alexandru Dima <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in web-server mode, there are a few issues loading extensions from the backend which run in the web extensionHost when they offer task providers or debug providers. e.g.:
Debugging this has shown this is due to a mismatch in extension IDs here (the loaded extension ID begins with
nullExtensionDescription
) and lack of registered debuggers found here.These issues are both due to a race condition where the extensionPaths initially used for loading fake extensions in the web extensionHost don't get updated when the host is started properly.
The flow seems to be:
vscode/src/vs/workbench/api/common/extHostRequireInterceptor.ts
Line 60 in eec8448
vscode/src/vs/workbench/api/common/extHostExtensionService.ts
Line 986 in eec8448
vscode/src/vs/workbench/api/common/extHostRequireInterceptor.ts
Line 165 in eec8448
vscode/src/vs/workbench/api/common/extHostRequireInterceptor.ts
Line 176 in eec8448
This PR adds an event for when the extensions are reloaded during the host start. This event is used to re-inject the updated extensionPaths. I'm pretty sure there's a better approach, so would be grateful of some support chaperoning this bug fix.