Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notebook-renderers compile error #179506

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Fix notebook-renderers compile error #179506

merged 2 commits into from
Apr 10, 2023

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Apr 7, 2023

There's a compile error that shows up in notebook-renderers depending on what's run.

yarn gulp compile-extensions-build <- OK, and also used by CI/build pipelines
yarn gulp compile-extension:notebook-renderers <- fail, but used by yarn compile or yarn watch
yarn gulp compile-extensions-build-legacy <- fail

I noticed that notebook-renderers is using esbuild, but I'm not sure how that causes the difference in behaviour above.

CC @joaomoreno

@rzhao271 rzhao271 self-assigned this Apr 7, 2023
@vscodenpa vscodenpa added this to the April 2023 milestone Apr 7, 2023
joyceerhl
joyceerhl previously approved these changes Apr 7, 2023
@rzhao271 rzhao271 force-pushed the rzhao271/notebook-types branch from 7e97bc6 to 427c742 Compare April 10, 2023 16:10
@rzhao271 rzhao271 requested a review from joyceerhl April 10, 2023 16:10
@rzhao271 rzhao271 enabled auto-merge (squash) April 10, 2023 16:10
@rzhao271 rzhao271 merged commit 8e89509 into main Apr 10, 2023
@rzhao271 rzhao271 deleted the rzhao271/notebook-types branch April 10, 2023 17:01
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants