-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jsx linked editing #176279
Merged
Merged
Add jsx linked editing #176279
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
49 changes: 49 additions & 0 deletions
49
extensions/typescript-language-features/src/languageFeatures/jsxLinkedEditing.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
/*--------------------------------------------------------------------------------------------- | ||
* Copyright (c) Microsoft Corporation. All rights reserved. | ||
* Licensed under the MIT License. See License.txt in the project root for license information. | ||
*--------------------------------------------------------------------------------------------*/ | ||
|
||
import * as vscode from 'vscode'; | ||
import { DocumentSelector } from '../configuration/documentSelector'; | ||
import { API } from '../tsServer/api'; | ||
import * as typeConverters from '../typeConverters'; | ||
import { ClientCapability, ITypeScriptServiceClient } from '../typescriptService'; | ||
import { conditionalRegistration, requireMinVersion, requireSomeCapability } from './util/dependentRegistration'; | ||
|
||
class JsxLinkedEditingSupport implements vscode.LinkedEditingRangeProvider { | ||
|
||
public static readonly minVersion = API.v510; | ||
|
||
public constructor( | ||
private readonly client: ITypeScriptServiceClient | ||
) { } | ||
|
||
async provideLinkedEditingRanges(document: vscode.TextDocument, position: vscode.Position, token: vscode.CancellationToken): Promise<vscode.LinkedEditingRanges | undefined> { | ||
const filepath = this.client.toOpenTsFilePath(document); | ||
if (!filepath) { | ||
return undefined; | ||
} | ||
|
||
const args = typeConverters.Position.toFileLocationRequestArgs(filepath, position); | ||
const response = await this.client.execute('linkedEditingRange', args, token); | ||
if (response.type !== 'response' || !response.body) { | ||
return undefined; | ||
} | ||
|
||
const wordPattern = response.body.wordPattern ? new RegExp(response.body.wordPattern) : undefined; | ||
return new vscode.LinkedEditingRanges(response.body.ranges.map(range => typeConverters.Range.fromTextSpan(range)), wordPattern); | ||
} | ||
} | ||
|
||
export function register( | ||
selector: DocumentSelector, | ||
client: ITypeScriptServiceClient | ||
) { | ||
return conditionalRegistration([ | ||
requireMinVersion(client, JsxLinkedEditingSupport.minVersion), | ||
requireSomeCapability(client, ClientCapability.Syntax), | ||
], () => { | ||
return vscode.languages.registerLinkedEditingRangeProvider(selector.semantic, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this be |
||
new JsxLinkedEditingSupport(client)); | ||
}); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit - you currently don't limit this to any JSX-specific file, so maybe we rename this to
LinkedEditingSupport
and just leave a comment about the main use-case being JSX tags?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Will follow up with these changes in a new PR