webview: ignore Ctrl+W and Ctrl+N in webview for PWA #164981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @mjbvz |
zhuowei
force-pushed
the
webview-pwa-ignore-ctrl-w
branch
from
820ebab to
3621e69
Compare
zhuowei
changed the title
This fixes closing Release Notes / Markdown Preview with Ctrl+W closing whole PWA. PWAs can intercept the Ctrl+W/Ctrl+N keystrokes, and VSCode does this for editor tabs. However, webviews do not intercept these keystrokes. If a webview such as Release Notes or Markdown Preview has focus: - when the user presses Ctrl+N, another instance of the PWA is opened in a new window. - when the user presses Ctrl+W, the whole PWA window closes. See microsoft#150735 for details. This fixes the issue by ignoring Ctrl+W and Ctrl+N in webviews. Tested on macOS 12.6 / Chrome Dev 109.0.5384.0: - patch environmentService.ts webviewExternalEndpoint to use http://localhost:8080/static/sources/out/vs/workbench/contrib/webview/browser/pre/ - followed the contributing instruction to run code-web - in Chrome, More Tools -> Create Shortcut -> Open as window - closed and re-opened Code OSS PWA window - opened chrome://inspect and inspected the Code OSS window - added an uncaught exception handler - opened file.md and chose "Open preview" - when it hit `Expected '${parentOriginHash}' as hostname or subdomain!` manually ran `start(parentOrigin)` in console and continued - the markdown preview now displayed - pressed Command+W Before: the whole window closes After: only the Markdown preview tab closes
zhuowei
force-pushed
the
webview-pwa-ignore-ctrl-w
branch
from
3621e69 to
f0d2ae7
Compare
zhuowei
changed the title
|
Updated PR to handle Ctrl+N as well. Questions:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes closing Release Notes / Markdown Preview with Ctrl+W closing whole PWA.
PWAs can intercept the Ctrl+W/Ctrl+N keystrokes, and VSCode does this for editor tabs. However, webviews do not intercept these keystrokes.
If a webview such as Release Notes or Markdown Preview has focus:
See #150735 for details.
This fixes the issue by ignoring Ctrl+W and Ctrl+N in webviews.
Tested on macOS 12.6 / Chrome Dev 109.0.5384.0:
Expected '${parentOriginHash}' as hostname or subdomain!manually ranstart(parentOrigin)in console and continuedBefore: the whole window closes
After: only the Markdown preview tab closes