api feedback #164470
Merged
api feedback #164470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sandy081
commented
Oct 24, 2022
sandy081
commented
- remove critical log level
- move log level off to be 0
- remove critical log level - move log level off to be 0
jrieken
previously approved these changes
Oct 24, 2022
rzhao271
reviewed
Oct 24, 2022
|
The following tests having to do with tasks fail: I'm not sure if the tests are just flaky, but other Code-OSS runs are green, so there might be a regression from this change. Re-running the CI once more to confirm, anyway. Edit: the Code-OSS CI is still failing. Moving this PR to the next milestone. |
This comment was marked as outdated.
This comment was marked as outdated.
rzhao271
reviewed
Oct 27, 2022
lramos15
approved these changes
Nov 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.