don't prompt for automatic tasks #162696
Closed
don't prompt for automatic tasks #162696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
reviewed
Oct 4, 2022
Comment on lines
+498
to
+500
| type: 'boolean', | ||
| description: nls.localize('task.allowAutomaticTasks', "Enable automatic tasks in any trusted workspace"), | ||
| default: true, |
There was a problem hiding this comment.
I thought we'd want to still keep auto, just change the default to on?
There was a problem hiding this comment.
Oh my thought was to get rid of the prompt entirely
There was a problem hiding this comment.
The poll we did was fairly inconclusive. I would still use off, but I suspect there are those who would still want it to be a per-workspace decision. Removing the previous default outright is quite risky
There was a problem hiding this comment.
We should also consider scope: ConfigurationScope.RESOURCE if we want it to be team choice vs user choice, and how that would interact with auto
|
we decided this should be discussed in the UX sync next week |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #160174