Fix #153860 #155086
Merged
Fix #153860 #155086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
reviewed
Jul 14, 2022
| const editorService = accessor.get(IEditorService); | ||
|
|
||
| await editorService.openEditor({ | ||
| resource: undefined, | ||
| resource: args?.path ? URI.from({ scheme: Schemas.untitled, path: `Untitled-${args.path}` }) : undefined, |
There was a problem hiding this comment.
This might break untitled assumptions: either it should be an untitled with associated path on disk or not set a resource at all, why is this done?
There was a problem hiding this comment.
I see for what it was added for. I am a bit worried that this could break the following regex:
So far, we had the assumption that Untitled-(number) is for untitled without associated resource and anything else has an associated resource. Untitled with associated resources typically do not ask where to save to because of the path.
There was a problem hiding this comment.
Hmm is there a way we could make this work? This is a very nice experience so far
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #153860
Allows creation of a named untitled file.
cc @bpasero As I added an arg to the command. Also can menus take arguments I only see command ID.