Search In Open Editors #107756
Merged
Search In Open Editors #107756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacksonKearl
force-pushed
the
jackson/search-in-editors
branch
from
2196c4a to
266916a
Compare
JacksonKearl
force-pushed
the
jackson/search-in-editors
branch
from
266916a to
f56d7fc
Compare
|
Looks good, I think it would be fine to begin with something like this and we can keep discussing fancier solutions. In case you aren't aware, this will also be hit by #62488 - only files that have been focused and loaded in this vscode session will be searched. Existing issue, but we may want to prioritize fixing that since this could make it more obvious. |
roblourens
reviewed
Jan 22, 2021
| @@ -42,6 +42,9 @@ export class RipgrepTextSearchEngine { | |||
|
|
|||
| const cwd = options.folder.fsPath; | |||
|
|
|||
| console.log({ query, options, rgArgs, cwd }); | |||
There was a problem hiding this comment.
Wait I removed that already, I think you're looking at an old version
There was a problem hiding this comment.
Ah I think the gh notification just takes me to some random new commit which is not necessarily the latest one
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress. Needs some larger architectural changes to search to allow for requesting results from a single file.
This PR fixes #106790