Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[html] auto rename broken state when deleting tags #86156

Closed
rebornix opened this issue Dec 3, 2019 · 2 comments
Closed

[html] auto rename broken state when deleting tags #86156

rebornix opened this issue Dec 3, 2019 · 2 comments
Assignees
@octref
Labels
info-needed Issue requires more information from poster
Milestone
November 2019

Comments

@rebornix
Copy link
Member

rebornix commented Dec 3, 2019

Testing #85973

<html>
    <foo>

    </foo>
</html>
  • put cursor at the end of foo of line 2
  • press backspace three times
  • auto rename mode doesn't exit, and leave the document in a weird state
@octref
Copy link
Contributor

octref commented Dec 5, 2019

When you don't have a complete pair, I think updating <f to <bar when you rename f to bar is fine. Or is your case different?

Kapture 2019-12-04 at 16 12 47

@octref octref added the info-needed Issue requires more information from poster label Dec 5, 2019
@octref octref added this to the November 2019 milestone Dec 5, 2019
@rebornix
Copy link
Member Author

rebornix commented Dec 5, 2019

This one seems caused actually by #86151

@rebornix rebornix closed this as completed Dec 5, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

Labels
info-needed Issue requires more information from poster
Projects
None yet
Milestone
November 2019
Development

No branches or pull requests
2 participants
@rebornix @octref