Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[html] auto rename doesn't exit when move cursor the end of line #86151

Closed
rebornix opened this issue Dec 3, 2019 · 4 comments
Closed

[html] auto rename doesn't exit when move cursor the end of line #86151

rebornix opened this issue Dec 3, 2019 · 4 comments
Assignees
@octref
Labels
bug Issue identified by VS Code Team member as probable bug html HTML support issues verified Verification succeeded
Milestone
November 2019

Comments

@rebornix
Copy link
Member

rebornix commented Dec 3, 2019 •
edited
Loading

Testing #85973

<html>
    <foo>

    </foo>
</html>
  • put cursor at the beginning of foo of line 2
  • press cmd+right
  • auto rename mode doesn't exit, there is still a secondary cursor on line 4
@rebornix
Copy link
Member Author

rebornix commented Dec 3, 2019

Another case

cursorend

<html>
    <foo>
    </foo>
</html>
  • Move cursor into foo of line 2
  • Move cursor to the end, there are two cursors
  • Move down, the cursors go into the tag

@octref
Copy link
Contributor

octref commented Dec 5, 2019

Initially I thought this would be nice for line-wise selection, especially if you do cmd+left/right, so I intentionally allowed this case.

Should we remove it?

For your second one:

  • When you move, two cursor became one
  • The first cursor went to </foo>, producing another cursor

So I'd say its behavior is fine

@octref octref added under-discussion Issue is under discussion for relevance, priority, approach html HTML support issues labels Dec 5, 2019
@octref octref added this to the November 2019 milestone Dec 5, 2019
@rebornix rebornix mentioned this issue Dec 5, 2019
Closed
@rebornix
Copy link
Member Author

rebornix commented Dec 5, 2019

Initially I thought this would be nice for line-wise selection, especially if you do cmd+left/right, so I intentionally allowed this case.

For line wise selection, I would expect it to work when I create multiple cursor myself.

@octref octref added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Dec 5, 2019
@octref
Copy link
Contributor

octref commented Dec 6, 2019

Verifier:

Have below HTML code (you can surround them with other HTML elements):

  <div>
  </div>

Put cursor inside div so mirror cursor occurs, and then move your cursor before < or after >. Make sure the 2 cursor become 1 when cursor is not on div anymore. Free free to jump around using Option/Cmd + arrow keys.

@octref octref closed this as completed in 7fada39 Dec 6, 2019
@sandy081 sandy081 added the verified Verification succeeded label Dec 6, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

Labels
bug Issue identified by VS Code Team member as probable bug html HTML support issues verified Verification succeeded
Projects
None yet
Milestone
November 2019
Development

No branches or pull requests
3 participants
@rebornix @octref @sandy081