Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCM Graph - pane loads indefinitely with non-git SCM extensions #234717

Closed
davidfirst opened this issue Nov 27, 2024 · 6 comments · Fixed by #236694
Closed

SCM Graph - pane loads indefinitely with non-git SCM extensions #234717

davidfirst opened this issue Nov 27, 2024 · 6 comments · Fixed by #236694
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders scm General SCM compound issues verified Verification succeeded
Milestone

Comments

@davidfirst
Copy link

Does this issue occur when all extensions are disabled?: Yes/No
No (the issue requires an SCM extension to be loaded).

  • VS Code Version: 1.95.3
  • OS Version: MacOS 14.6.1

Steps to Reproduce:

  1. Create an empty directory and open it in VS Code. Ensure that Git is not initialized in this directory.
  2. Install an SCM extension other than Git. For example, the Mercurial Hg extension (id: mrcrowl.hg).
  3. Initialize the repo. For Hg, execute Hg: Initialize Repository (Hg) from the Command Palette.
  4. Click on the Source Control (SCM) icon in the Activity Bar.
  5. Notice that the “Source Control Graph” pane displays a loading indicator indefinitely.

I am the developer of the "bit" extension, which also provides SCM capabilities, I initially observed this issue with my extension. To ensure the problem is not specific to my extension, I tested it with Hg and encountered the same issue.

If there is a way for me to provide my own graph according to my source control, this will be even better.
Even maybe an option to disable it from the settings. (I know it's possible from the UI to deselect it, but I can't control it programmatically). I came across an older youtube video showing a settings to disable it: "SCM: experimental: Show History Graph" but sadly it's not available anymore.

Image

@lszomoru lszomoru added scm General SCM compound issues bug Issue identified by VS Code Team member as probable bug labels Nov 27, 2024
@netopsengineer
Copy link

netopsengineer commented Nov 29, 2024

I have noticed this on the latest release and could not find an issue that matched it, but I think the Conventional Commits extension is what is leading to me seeing the perpetual loading of the SCM panel.

What I noticed is that when this happens, which isn't immediately on launch, it seems to be several minutes later, I'll see the icon with the clock on the sidebar for the SCM panel show up like its loading, at that point several other extensions like Copilot and such stop working, and/or hang indefinitely until I reload the window. @davidfirst are you seeing similar behavior?

Edit: After disabling that extension I see the very next extension that tried to do anything related to Git, set the panel to perpetual loading cycle and the Extension Host output shows:

2024-11-29 10:05:50.747 [info] ExtensionService#_doActivateExtension vscode.git-base, startup: false, activationEvent: 'onLanguage:python', root cause: Codium.codium

@hrodas
Copy link

hrodas commented Nov 29, 2024 via email

@davidfirst
Copy link
Author

@netopsengineer , nope, I don't use Conventional Commits extension and I don't see the log error you got.
All I see if I select git in the output (which is expected) is: fatal: not a git repository (or any of the parent directories): .git

@PhoneixS
Copy link

PhoneixS commented Dec 3, 2024

Also, after implementing a way for other extensions to provide a "graph", it would be nice to have the documentation added on https://code.visualstudio.com/api/extension-guides/scm-provider about how to do it.

@lszomoru lszomoru added this to the On Deck milestone Dec 10, 2024
@lszomoru lszomoru changed the title Source Control Graph pane loads indefinitely with non-git SCM extensions SCM Graph - pane loads indefinitely with non-git SCM extensions Dec 13, 2024
@lszomoru lszomoru modified the milestones: On Deck, January 2025 Dec 20, 2024
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Dec 20, 2024
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 6, 2025
@rzhao271 rzhao271 added the author-verification-requested Issues potentially verifiable by issue author label Jan 30, 2025
Copy link

This bug has been fixed in the latest release of VS Code Insiders!

@davidfirst, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version d991749 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label Jan 31, 2025
@davidfirst
Copy link
Author

/verified

@vs-code-engineering vs-code-engineering bot removed the author-verification-requested Issues potentially verifiable by issue author label Feb 2, 2025
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders scm General SCM compound issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants