Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable command returning null does not cancel debug session launch #18601

Closed
weinand opened this issue Jan 16, 2017 · 0 comments
Closed

Variable command returning null does not cancel debug session launch #18601

weinand opened this issue Jan 16, 2017 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues important Issue identified as high-priority verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Jan 16, 2017

  • VSCode Version: 1.9.0
  • OS Version: macOS

Steps to Reproduce:

  1. use this launch config:
{
	"type": "node",
	"request": "attach",
	"name": "Attach to Port",
	"port": 5858,
	"processId": "${command.PickProcess}"
}
  1. start "Attach to Port"
  2. Press 'Esc' to cancel

Observe:
this error appears:
2017-01-16_11-42-37

I've verified that the variable command returns a null in this case but this only cancels the variable substitution (and leaves the variable expression intact) but not the debug session launch.

@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Jan 16, 2017
@weinand weinand added this to the January 2017 milestone Jan 16, 2017
@dbaeumer dbaeumer added the verified Verification succeeded label Jan 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants