Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger: Attach to process: 'null' doesn't look like a process id. #16271

Closed
normalser opened this issue Nov 30, 2016 · 4 comments
Closed

Debugger: Attach to process: 'null' doesn't look like a process id. #16271

normalser opened this issue Nov 30, 2016 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s)
Milestone

Comments

@normalser
Copy link

  • VSCode Version: Code - Insiders 1.8.0-insider (2bd85b8, 2016-11-30T07:05:07.830Z)
  • OS Version: Darwin x64 16.1.0

Steps to Reproduce:

  1. Press F5

  2. Input box gets displayed with:
    image

  3. Press Esc

  4. You get:
    image

Should probably just close the input box from step #2

@chrmarti chrmarti added the bug Issue identified by VS Code Team member as probable bug label Nov 30, 2016
@chrmarti
Copy link
Collaborator

Reproduced with:

        {
            "type": "node",
            "request": "attach",
            "name": "Attach to Process",
            "processId": "${command.PickProcess}"
        }

@chrmarti chrmarti added the debug Debug viewlet, configurations, breakpoints, adapter issues label Nov 30, 2016
@isidorn isidorn modified the milestones: November 2016, January 2017 Dec 1, 2016
@isidorn
Copy link
Contributor

isidorn commented Dec 13, 2016

I simply improved the error message
Yes, ideally we would not even start debugging but that would require some checking of the launch.json for unreplaced variables which is ugly code that I do not want to introduce.
@weinand can improve this message on the adapter side if needed

screen shot 2016-12-13 at 10 59 18

@weinand weinand assigned weinand and unassigned isidorn Dec 13, 2016
@weinand weinand reopened this Dec 13, 2016
@weinand
Copy link
Contributor

weinand commented Jan 23, 2017

@isidorn you've fixed this with a real fix for Jan 2017. Please add a comment what you did and close the issue.

@weinand weinand assigned isidorn and unassigned weinand Jan 23, 2017
@isidorn
Copy link
Contributor

isidorn commented Jan 23, 2017

Dup of #18601
Now the cancelation of replacment by the user is nicely propagating through so the debug service does not continue with the launch / attach request

@isidorn isidorn closed this as completed Jan 23, 2017
@isidorn isidorn added the *duplicate Issue identified as a duplicate of another issue(s) label Jan 23, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

4 participants