Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor.selectionClipboard option has no effect on vscode.dev #181050

Open
dlech opened this issue Apr 27, 2023 · 1 comment
Open

editor.selectionClipboard option has no effect on vscode.dev #181050

dlech opened this issue Apr 27, 2023 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-clipboard Editor clipboard issues
Milestone

Comments

@dlech
Copy link
Contributor

dlech commented Apr 27, 2023

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.77.3
  • OS Version: Ubuntu 22.04

Steps to Reproduce:

  1. Set editor.selectionClipboard to False in the settings.
  2. Create a new empty text file.
  3. Write some text.
  4. Select the text.
  5. Middle click.

In the desktop app, changing the setting affects the behavior, however in vscode.dev in a Chromium browser, the setting has no effect.

Desktop app working as expected:

vokoscreenNG-2023-04-27_11-37-47.webm

Web app (vscode.dev) not working as expected:

vokoscreenNG-2023-04-27_11-40-48.webm
dlech added a commit to pybricks/pybricks-code that referenced this issue Apr 27, 2023
To avoid the Linux feature of pasting on middle click, we need to
consume the mouse up event in the browser on middle click instead of
mouse down.

This also sets the `selectionClipboard` editor option to false which
should disable the feature altogether in the monaco editor but the
setting seems to be broken in the browser[1].

[1]: microsoft/vscode#181050

Fixes: pybricks/support#1046
dlech added a commit to pybricks/pybricks-code that referenced this issue Apr 27, 2023
To avoid the Linux feature of pasting on middle click, we need to
consume the mouse up event in the browser on middle click instead of
mouse down.

This also sets the `selectionClipboard` editor option to false which
should disable the feature altogether in the monaco editor but the
setting seems to be broken in the browser[1].

[1]: microsoft/vscode#181050

Fixes: pybricks/support#1046
@alexdima
Copy link
Member

The reason is because this code which would prevent pasting is registered as a workbench contribution and workbench contributions don't get instantiated in the standalone editor. That could be transformed to the newly available IEditorFeature.

@alexdima alexdima added the editor-clipboard Editor clipboard issues label Apr 28, 2023
@alexdima alexdima added this to the May 2023 milestone Apr 28, 2023
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Apr 28, 2023
@alexdima alexdima modified the milestones: May 2023, June 2023 Jun 1, 2023
@alexr00 alexr00 modified the milestones: June 2023, July 2023 Jun 27, 2023
@alexdima alexdima modified the milestones: July 2023, August 2023 Jul 26, 2023
@alexdima alexdima modified the milestones: August 2023, September 2023 Aug 31, 2023
@alexdima alexdima modified the milestones: September 2023, October 2023 Sep 28, 2023
@alexdima alexdima modified the milestones: October 2023, November 2023 Oct 25, 2023
@alexdima alexdima modified the milestones: November 2023, December 2023 Nov 30, 2023
@alexdima alexdima modified the milestones: December / January 2024, February 2024 Jan 25, 2024
@alexdima alexdima modified the milestones: February 2024, March 2024 Feb 22, 2024
@alexdima alexdima modified the milestones: March 2024, On Deck Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug editor-clipboard Editor clipboard issues
Projects
None yet
Development

No branches or pull requests

3 participants