Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept Word does not work across lines #172162

Closed
isidorn opened this issue Jan 24, 2023 · 3 comments · Fixed by #179988
Closed

Accept Word does not work across lines #172162

isidorn opened this issue Jan 24, 2023 · 3 comments · Fixed by #179988
Assignees
@hediet
Labels
bug Issue identified by VS Code Team member as probable bug inline-completions insiders-released Patch has been released in VS Code Insiders plan-item VS Code - planned item for upcoming verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2023

Comments

@isidorn
Copy link
Contributor

isidorn commented Jan 24, 2023

Testing #172029

Currently my top pain point with using Accept Word in inline suggestions is that it does not go across lines. Once I get to the end of line I can not trigger it anymore to start accepting words from the second line.

fyi @jrieken
@hediet hediet added the bug Issue identified by VS Code Team member as probable bug label Jan 25, 2023
@hediet hediet added this to the On Deck milestone Jan 25, 2023
@hediet
Copy link
Member

hediet commented Jan 25, 2023

Fixing this bug requires some re-architecturing:
As soon as the cursor changes the line, the session is being thrown away and new inline completions are asked for the new line.

@isidorn isidorn mentioned this issue Jan 26, 2023
Closed
@njiang747 njiang747 mentioned this issue Feb 2, 2023
Closed
@kieferrm kieferrm mentioned this issue Apr 2, 2023
Closed
90 tasks
@hediet hediet added the plan-item VS Code - planned item for upcoming label Apr 4, 2023
hediet added a commit that referenced this issue Apr 14, 2023
@hediet
Rewrites the inline completion feature.
e619464 
Fixes #172162
Fixes #174329
Fixes #172153
Fixes #164716
@hediet hediet mentioned this issue Apr 14, 2023
Merged
hediet added a commit that referenced this issue Apr 17, 2023
@hediet
Rewrites the inline completion feature.
5170534 
Fixes #172162
Fixes #174329
Fixes #172153
Fixes #164716
Fixes #170527
hediet added a commit that referenced this issue Apr 17, 2023
@hediet
Rewrites the inline completion feature.
fb1af29 
Fixes #172162
Fixes #174329
Fixes #172153
Fixes #164716
Fixes #170527
hediet added a commit that referenced this issue Apr 17, 2023
@hediet
Rewrites the inline completion feature.
cb0e59c 
Fixes #172162
Fixes #174329
Fixes #172153
Fixes #164716
Fixes #170527
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Apr 17, 2023
@isidorn isidorn modified the milestones: On Deck, April 2023 Apr 17, 2023
@isidorn
Copy link
Contributor Author

isidorn commented Apr 17, 2023

@hediet would you like to create a test plan item for this, or would you like me to verify it and we add verification-needed here?

@hediet hediet added the verification-needed Verification of issue is requested label Apr 17, 2023
@hediet
Copy link
Member

hediet commented Apr 17, 2023

I'll create a general test plan item to test various sub-features of the inline completion feature, as the rewrite touched everything.

I'll add the label here just to get more coverage.

@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 17, 2023
@mjbvz mjbvz added the verified Verification succeeded label Apr 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
bug Issue identified by VS Code Team member as probable bug inline-completions insiders-released Patch has been released in VS Code Insiders plan-item VS Code - planned item for upcoming verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2023
Development

Successfully merging a pull request may close this issue.

Rewrites the inline completion feature. microsoft/vscode
4 participants
@isidorn @hediet @mjbvz @vscodenpa