Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown link update incorrectly updating fragment links #164932

Closed
mjbvz opened this issue Oct 28, 2022 · 0 comments
Closed

Markdown link update incorrectly updating fragment links #164932

mjbvz opened this issue Oct 28, 2022 · 0 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release markdown Markdown support issues verified Verification succeeded
Milestone
October 2022

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Oct 28, 2022 •
edited
Loading

Type: Bug

  1. Enable markdown.updateLinksOnFileMove.enabled
  2. With workspace:
sub/
    readme.md
  1. In readme.md:
# First Header

[A link to header](#first-header)
  1. Drag readme.md to top level of workspace

bug
The link is incorrectly rewritten to include the file name [A link to header](readme.md#first-header)

VS Code version: Code - Insiders 1.73.0-insider (Universal) (3544aab, 2022-10-27T21:41:11.954Z)
OS version: Darwin x64 21.6.0
Modes:
Sandboxed: Yes

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off
Load (avg) 5, 6, 5
Memory (System) 32.00GB (0.03GB free)
Process Argv --crash-reporter-id 48781ca2-1705-4f64-9bab-325055aab55d
Screen Reader no
VM 0%
@mjbvz mjbvz self-assigned this Oct 28, 2022
@mjbvz mjbvz added this to the October 2022 milestone Oct 28, 2022
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues labels Oct 28, 2022
@mjbvz mjbvz mentioned this issue Oct 28, 2022
Merged
mjbvz added a commit to mjbvz/vscode that referenced this issue Oct 29, 2022
@mjbvz
Port md fixes to release branch
9a80738 
This is a cherry pick of two fixes:

- microsoft#164945 which fixes microsoft#164932 by picking up a new md language service version

- microsoft#164942 which fixes microsoft#164562 by fixing a bug with the md workspace implementation
@mjbvz mjbvz mentioned this issue Oct 29, 2022
Merged
mjbvz added a commit that referenced this issue Oct 31, 2022
@mjbvz
Port md fixes to release branch (#164986)
dd1e484 
This is a cherry pick of two fixes:

- #164945 which fixes #164932 by picking up a new md language service version

- #164942 which fixes #164562 by fixing a bug with the md workspace implementation
@rebornix rebornix added the candidate Issue identified as probable candidate for fixing in the next release label Oct 31, 2022
@mjbvz mjbvz closed this as completed Oct 31, 2022
@rebornix rebornix added the verified Verification succeeded label Nov 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release markdown Markdown support issues verified Verification succeeded
Projects
None yet
Milestone
October 2022
Development

No branches or pull requests
2 participants
@rebornix @mjbvz