Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window.commandCenter setting description references setting window.titleBarStyle in web #164768

Closed
joyceerhl opened this issue Oct 26, 2022 · 1 comment · Fixed by #165068
Closed

window.commandCenter setting description references setting window.titleBarStyle in web #164768

joyceerhl opened this issue Oct 26, 2022 · 1 comment · Fixed by #165068
Assignees
@jrieken @sbatten
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders titlebar VS Code main title bar issues verified Verification succeeded
Milestone
November 2022

Comments

@joyceerhl
Copy link
Collaborator

Clicking the setting link just clears the settings UI editor query

image
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug titlebar VS Code main title bar issues labels Oct 27, 2022
@jrieken
Copy link
Member

jrieken commented Oct 27, 2022

Yeah, the problem is that the setting doesn't exist for web. The same applies to the window.menuBarVisibility setting

@sbatten sbatten added this to the November 2022 milestone Oct 27, 2022
@sbatten sbatten mentioned this issue Oct 31, 2022
Merged
sbatten added a commit that referenced this issue Oct 31, 2022
@sbatten
improve title bar settings for web
a52511e 
fixes #164768
@sbatten sbatten modified the milestone: November 2022 Oct 31, 2022
sbatten added a commit that referenced this issue Oct 31, 2022
@sbatten
improve title bar settings for web (#165068)
3dc149a 
fixes #164768
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 31, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders titlebar VS Code main title bar issues verified Verification succeeded
Projects
None yet
Milestone
November 2022
Development

Successfully merging a pull request may close this issue.

improve title bar settings for web microsoft/vscode
4 participants
@jrieken @sbatten @joyceerhl @vscodenpa