Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API documentation issues #164617

Closed
weinand opened this issue Oct 25, 2022 · 0 comments
Closed

API documentation issues #164617

weinand opened this issue Oct 25, 2022 · 0 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders log VS Code log issues verified Verification succeeded
Milestone
October 2022

Comments

@weinand
Copy link
Contributor

weinand commented Oct 25, 2022 •
edited
Loading

Testing #164434

  • the API lacks an explanation of the interaction between channel log levels and app log levels.
  • the comments of the individual log methods all have the form "Messages are only printed when the user has enabled xxx logging" but nowhere is explained how "xxx logging enablement" is related to the log level. I would rather expect something like "xxx messages are only logged when the log level is xxx or lower."
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug log VS Code log issues labels Oct 26, 2022
@sandy081 sandy081 added this to the October 2022 milestone Oct 26, 2022
sandy081 added a commit that referenced this issue Oct 26, 2022
@sandy081
Fix #164617
184c0a1
@sandy081 sandy081 mentioned this issue Oct 26, 2022
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 26, 2022
formigoni pushed a commit to formigoni/vscode that referenced this issue Oct 27, 2022
@sandy081 @formigoni
Fix microsoft#164617 (microsoft#164717)
60ff96a
@lramos15 lramos15 added the verified Verification succeeded label Oct 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders log VS Code log issues verified Verification succeeded
Projects
None yet
Milestone
October 2022
Development

No branches or pull requests
4 participants
@weinand @lramos15 @sandy081 @vscodenpa