Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicating Menu Actions when switching profiles #161910

Closed
benibenj opened this issue Sep 27, 2022 · 1 comment · Fixed by #165274
Closed

Duplicating Menu Actions when switching profiles #161910

benibenj opened this issue Sep 27, 2022 · 1 comment · Fixed by #165274
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tree-views Extension tree view issues verified Verification succeeded
Milestone
November 2022

Comments

@benibenj
Copy link
Contributor

I'm not entirely sure how to reproduce this, but this is what I did:

  1. Played around with hiding title actions in the "Remote Explorer" Panel view. Hid both Refresh and Collapse action and reset the menu again.
  2. When switching to a profile which does not have the extension and then switching back, the Collapse action duplicated

image

It also propagated into other view panes such as the GitHub PR extension

image

I don't think it's related to hiding. Possibly some cleanup tasks not removing all menu groups it should...?
@benibenj benibenj added the bug Issue identified by VS Code Team member as probable bug label Sep 27, 2022
@sandy081
Copy link
Member

Yes, it is not related to showing/hiding actions. It can be reproduced by not toggling visibility.

  • Open Pull Requests View
  • Switch to a profile that does not has Pull Request view
  • Switch back to the previous profile
    🐛 Collapse All action is duplicated.

Only Collapse All action is getting duplicated. Seems like a tree view bug.

@sandy081 sandy081 assigned alexr00 and unassigned sandy081 Sep 27, 2022
@alexr00 alexr00 added this to the October 2022 milestone Sep 29, 2022
@alexr00 alexr00 modified the milestones: October 2022, November 2022 Oct 25, 2022
@alexr00 alexr00 added the tree-views Extension tree view issues label Nov 2, 2022
@alexr00 alexr00 mentioned this issue Nov 2, 2022
Merged
alexr00 added a commit that referenced this issue Nov 2, 2022
@alexr00
Duplicating Menu Actions when switching profiles
2edc1ad 
Fixes #161910
alexr00 added a commit that referenced this issue Nov 2, 2022
@alexr00
Duplicating Menu Actions when switching profiles (#165274)
14d922c 
Fixes #161910
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 2, 2022
@aeschli aeschli added the verified Verification succeeded label Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tree-views Extension tree view issues verified Verification succeeded
Projects
None yet
Milestone
November 2022
Development

Successfully merging a pull request may close this issue.

Duplicating Menu Actions when switching profiles microsoft/vscode
5 participants
@aeschli @sandy081 @alexr00 @benibenj @vscodenpa