Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can't rename HTML tag in jsx by F2 #159534

Closed
tjx666 opened this issue Aug 30, 2022 · 7 comments · Fixed by #179806
Closed

can't rename HTML tag in jsx by F2 #159534

tjx666 opened this issue Aug 30, 2022 · 7 comments · Fixed by #179806
Assignees
@mjbvz
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders javascript JavaScript support issues typescript Typescript support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2023

Comments

@tjx666
Copy link
Contributor

tjx666 commented Aug 30, 2022

image

@mjbvz @rzhao271

Version: 1.71.0-insider (Universal)
Commit: 16faaf4eb07424d5d7dba7d12bffd64309c283f7
Date: 2022-08-29T15:28:34.899Z
Electron: 19.0.12
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin x64 21.6.0
Sandboxed: Yes
@tjx666 tjx666 changed the title can't rename HTML tag in jsx can't rename HTML tag in jsx by F2 Aug 30, 2022
@aeschli aeschli assigned mjbvz and unassigned aeschli Aug 30, 2022
@mjbvz mjbvz added the feature-request Request for new features or functionality label Aug 30, 2022
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Aug 30, 2022
@vscodenpa
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@mjbvz mjbvz added the webview Webview issues label Sep 21, 2022
@mjbvz mjbvz mentioned this issue Sep 26, 2022
Closed
@vscodenpa
Copy link

🙂 This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa vscodenpa modified the milestones: Backlog Candidates, Backlog Oct 7, 2022
@mjbvz mjbvz added the *out-of-scope Posted issue is not in scope of VS Code label Dec 5, 2022
@vscodenpa

This comment was marked as outdated.

Sign in to view
@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2022
@bdharrington7

This comment was marked as outdated.

Sign in to view
@mhmdAljefri

This comment was marked as duplicate.

Sign in to view
@AscenKeeprov

This comment was marked as duplicate.

Sign in to view
@mjbvz mjbvz removed the *out-of-scope Posted issue is not in scope of VS Code label Apr 12, 2023
@mjbvz mjbvz modified the milestones: Backlog, April 2023 Apr 12, 2023
@mjbvz mjbvz added typescript Typescript support issues javascript JavaScript support issues and removed webview Webview issues labels Apr 12, 2023
@mjbvz mjbvz reopened this Apr 12, 2023
mjbvz added a commit to mjbvz/vscode that referenced this issue Apr 12, 2023
@mjbvz
Enable renaming of matching jsx tags
330113c 
Fixes microsoft#159534

Uses the new linked editing api to make f2 rename matching jsx tags
@mjbvz mjbvz mentioned this issue Apr 12, 2023
Merged
mjbvz added a commit that referenced this issue Apr 12, 2023
@mjbvz
Enable renaming of matching jsx tags (#179806)
26ccce4 
Fixes #159534

Uses the new linked editing api to make f2 rename matching jsx tags
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Apr 12, 2023
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 14, 2023
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 24, 2023

To verify:

  1. Default renames should rename matching tags now. Test on both html tag names (<div>) and custom components (<Button>)

  2. If you change typescript.preferences.renameMatchingJsxTags, then renaming custom components should instead renaming all references to that component

@mjbvz mjbvz added the verification-needed Verification of issue is requested label Apr 24, 2023
@vscodenpa vscodenpa mentioned this issue Apr 24, 2023
Closed
@aiday-mar aiday-mar added the verified Verification succeeded label Apr 25, 2023
@mjbvz mjbvz mentioned this issue Apr 25, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders javascript JavaScript support issues typescript Typescript support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2023
Development

Successfully merging a pull request may close this issue.

Enable renaming of matching jsx tags mjbvz/vscode
8 participants
@bdharrington7 @aeschli @mjbvz @mhmdAljefri @AscenKeeprov @tjx666 @aiday-mar @vscodenpa