Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new notebook workspace edit api #149181

Closed
4 tasks done
Tracked by #149861
mjbvz opened this issue May 10, 2022 · 4 comments · Fixed by #158988
Closed
4 tasks done
Tracked by #149861

Migrate to new notebook workspace edit api #149181

mjbvz opened this issue May 10, 2022 · 4 comments · Fixed by #158988
Assignees
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented May 10, 2022

We've working on cleaning up how extensions can apply edits to notebooks. As part of this, we will be removing the notebookEditorEdit API proposal and replacing it with a new notebookWorkspaceEdit api proposal. Main changes:

  • Edits are now expressed using a NotebookEdit object
  • We've removed the NotebookEditor.edit edit builder function entirely

The functionality of this new api should be the same as the old API. You can find the current api here

Here's a list of current consumers:

@mjbvz mjbvz added this to the May 2022 milestone May 10, 2022
@mjbvz mjbvz self-assigned this May 10, 2022
@mjbvz
Copy link
Collaborator Author

mjbvz commented May 16, 2022

Merged in new proposal with #149128

@mjbvz
Copy link
Collaborator Author

mjbvz commented May 23, 2022

Hey @rchiodo, can you please take a look at the new API proposal and me know if you have any feedback on it? We want to make sure it looks ok for Jupyter before asking other extensions migrate over too

@rchiodo
Copy link
Contributor

rchiodo commented May 23, 2022

Just glancing at it looks fine. We'd have to port to it I think before we could comment on what might or might not work.

@mjbvz
Copy link
Collaborator Author

mjbvz commented Aug 23, 2022

All users have now been migrated over. Just need to remove the api itself now

@mjbvz mjbvz modified the milestones: August 2022, September 2022 Aug 23, 2022
mjbvz added a commit to mjbvz/vscode that referenced this issue Aug 23, 2022
@mjbvz mjbvz added debt Code quality issues and removed api-proposal labels Aug 23, 2022
mjbvz added a commit that referenced this issue Aug 29, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2022
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants