-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to new notebook workspace edit api #149181
Comments
Merged in new proposal with #149128 |
Hey @rchiodo, can you please take a look at the new API proposal and me know if you have any feedback on it? We want to make sure it looks ok for Jupyter before asking other extensions migrate over too |
Just glancing at it looks fine. We'd have to port to it I think before we could comment on what might or might not work. |
All users have now been migrated over. Just need to remove the api itself now |
We've working on cleaning up how extensions can apply edits to notebooks. As part of this, we will be removing the
notebookEditorEdit
API proposal and replacing it with a newnotebookWorkspaceEdit
api proposal. Main changes:NotebookEdit
objectNotebookEditor.edit
edit builder function entirelyThe functionality of this new api should be the same as the old API. You can find the current api here
Here's a list of current consumers:
The text was updated successfully, but these errors were encountered: