Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support calling additional resolveDebugConfiguration callbacks if one callback changes the debug configuration type #142135

Closed
jkoritzinsky opened this issue Feb 3, 2022 · 1 comment · Fixed by #143054
Closed

Support calling additional resolveDebugConfiguration callbacks if one callback changes the debug configuration type #142135

jkoritzinsky opened this issue Feb 3, 2022 · 1 comment · Fixed by #143054
Assignees
@roblourens @connor4312
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Milestone
On Deck

Comments

@jkoritzinsky
Copy link
Member

Today, VSCode's debug configuration provider API provides partial support for extensions that change the type property on a debug configuration returned by the resolveDebugConfiguration on a provider. The support today includes activating debuggers for the new debug configuration type. This support was added in 4150347 to fix #135090.

However, this support does not include running the resolveDebugConfiguration callback for configuration providers keyed off the new type. This would be desireable for extensions that run highly customized debug configurations whose resolved configuration's type may differ depending on other installed extensions, target platform, or on user input.

I would be willing to contribute an implementation of this feature if the idea is amenable.
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Feb 4, 2022
jkoritzinsky added a commit to jkoritzinsky/vscode that referenced this issue Feb 14, 2022
@jkoritzinsky
Run DebugConfigurationProviders for the result type of another DebugC…
a0965b8 
…onfigurationProvider

This enables chaining `DebugConfigurationProvider`s with two or more `type` changes (one `type` change is already supported) and calling `DebugConfigurationProvider`'s `resolveConfigurationsByProviders` callback when providers are chained.

Fixes microsoft#142135

I'm not sure where to add tests, so I would appreciate any pointers.
@jkoritzinsky jkoritzinsky mentioned this issue Feb 14, 2022
Merged
@weinand weinand added this to the On Deck milestone Mar 14, 2022
@weinand weinand removed their assignment Oct 19, 2022
@roblourens roblourens added the feature-request Request for new features or functionality label Nov 21, 2022
@connor4312
Copy link
Member

Duplicates #110889

@connor4312 connor4312 added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@connor4312 connor4312

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Projects
None yet
Milestone
On Deck
4 participants
@roblourens @jkoritzinsky @weinand @connor4312