Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command to change which cursor is primary #135460

Closed
isidorn opened this issue Oct 20, 2021 · 8 comments · Fixed by #145909
Closed

Command to change which cursor is primary #135460

isidorn opened this issue Oct 20, 2021 · 8 comments · Fixed by #145909
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues editor-multicursor Editor multiple cursor issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Oct 20, 2021

When a user adds multiple cursors we nicely announce the locations for each additional cursors.
However the user can not check what is going on at the second / third cursor.

I thought it would be nice if the user could change which one is the primary cursor using a command. That way the user could traverse each of the cursors and be able to read the line on each cursor for example. Since for screen reader reading we only respect the primary cursor.

Now I am not sure if this is even possible from the implementation. Thus I am creating this issue for discussion.
I am also open for ideas.

@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues under-discussion Issue is under discussion for relevance, priority, approach labels Oct 20, 2021
@hediet
Copy link
Member

hediet commented Oct 20, 2021

Currently, the primary cursor is always the first one, right?

@isidorn
Copy link
Contributor Author

isidorn commented Oct 20, 2021

Yes.

@isidorn isidorn added the editor-multicursor Editor multiple cursor issues label Oct 20, 2021
@alexdima
Copy link
Member

I like the suggestion, such a command ("focus next cursor") should be straight-forward to implement using editor API from an editor contrib.

@isidorn
Copy link
Contributor Author

isidorn commented Oct 20, 2021

Great. I like the "Focus Next Cursor" name. Maybe we also introduce "Focus Previous Cursor". I suggest no keybinding by default and then users can assign whatever they prefer.
Maybe we assign this to November if it is low hanging fruit?

@alexdima alexdima added this to the November 2021 milestone Oct 20, 2021
@alexdima alexdima added feature-request Request for new features or functionality and removed under-discussion Issue is under discussion for relevance, priority, approach labels Oct 20, 2021
@JonathanAckerman
Copy link

This feature could go well with #85630 to have clear visual feedback for when the primary cursor changes.

@isidorn
Copy link
Contributor Author

isidorn commented Mar 30, 2022

Thanks a lot for pushing this @hediet 👏

Once this is in insiders tomorrow I will do a push in our accessibility community for multi cursor, since I think with this it should be much more usable. So we get feedback.
Did you verify if you change the focus of the cursor, does the screen reader read the new line (where the newly focused cursor is). I believe it should just work.

@joyceerhl joyceerhl added the verification-needed Verification of issue is requested label Apr 25, 2022
@hediet
Copy link
Member

hediet commented Apr 27, 2022

Verification steps:

  • Launch nvda
  • Set multiple cursors
  • Use "Focus Next Cursor" / "Focus Previous Cursor"
  • Verify that NVDA reads the text of the primary cursor and that the primary cursor rotates

@isidorn isidorn added the verified Verification succeeded label Apr 27, 2022
@isidorn
Copy link
Contributor Author

isidorn commented Apr 27, 2022

Works great 👏

@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues editor-multicursor Editor multiple cursor issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@isidorn @hediet @alexdima @JonathanAckerman @joyceerhl and others