Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when searching in open user settings.json #115176

Closed
gregvanl opened this issue Jan 27, 2021 · 4 comments
Closed

Error when searching in open user settings.json #115176

gregvanl opened this issue Jan 27, 2021 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders search Search widget and operation issues verified Verification succeeded

Comments

@gregvanl
Copy link

Testing #114970

With Search only in Open Editors enabled, open the user settings.json and try to search.

image

Doesn't seem to happen with an open workspace settings.json

@gregvanl
Copy link
Author

Seems to be a problem for any file under my user AppData folder. Also repros for keybindings.json

image

@gregvanl
Copy link
Author

Seems like the feature needs the files to be under the workspace root. Adding loose files from outside the workspace break it.

@gjsjohnmurray
Copy link
Contributor

/assign @JacksonKearl

@JacksonKearl
Copy link
Contributor

JacksonKearl commented Jan 27, 2021

Thanks, this should be fixed now, it won't error but it also wont provide results for the user data files yet (tracking in #114795 (comment)). Results should be provided for free standing files though.

image

@JacksonKearl JacksonKearl added insiders-released Patch has been released in VS Code Insiders bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels Jan 27, 2021
@gregvanl gregvanl added the verified Verification succeeded label Jan 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders search Search widget and operation issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants