Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Search in Open Editors #114970

Closed
3 tasks done
JacksonKearl opened this issue Jan 26, 2021 · 0 comments
Closed
3 tasks done

Test: Search in Open Editors #114970

JacksonKearl opened this issue Jan 26, 2021 · 0 comments

Comments

@JacksonKearl
Copy link
Contributor

JacksonKearl commented Jan 26, 2021

Refs: #106790

Complexity: 3

Create Issue


Background

Added support for searching in all open editors. This is potentially a precursor to searching in a variety of extension-contributed file sets, but for now the only exposure is for open editors.

Testing

  • Ensure "search.experimental.searchInOpenEditors": true (default in insiders)
  • Open some editors
    • In a single folder workspace
    • Multiroot workspace
    • Freestanding files in empty workspaces (or normal workspaces)
    • Configuration files (settings.json, etc.)
  • Search for entries in those files. Try out both searches for contents on disk, and searches for contents only in local changes
  • Test out the includes/excludes fields, they should filter down the existing editors.
  • Reload
  • Search again, entries should still show up.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants