Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear when SymbolTreeInput#with is called #107710

Closed
dbaeumer opened this issue Sep 29, 2020 · 2 comments
Closed

Unclear when SymbolTreeInput#with is called #107710

dbaeumer opened this issue Sep 29, 2020 · 2 comments
Assignees
Labels
polish Cleanup and polish issue references-viewlet under-discussion Issue is under discussion for relevance, priority, approach

Comments

@dbaeumer
Copy link
Member

Testing #107585

I was not able to make the widget call that method. I also have difficulties to understand what my responsibility is in terms of implementing it: is position the current position in the editor of a tracked position on which the reference provider was called before?

@jrieken
Copy link
Member

jrieken commented Sep 29, 2020

is position the current position in the editor of a tracked position on which the reference provider was called before?

Yeah, more or less. When the original input was created for word "foo" then we try to find the word again when re-running from history. What you have to do is create a new instance of your input with a location having that position. I agree it's cumbersome. The challenge is that the input is just an interface and I don't know how to "tweak" instances of it. That's why I make you implement this function...

@jrieken jrieken added this to the September 2020 milestone Sep 29, 2020
@jrieken jrieken added references-viewlet under-discussion Issue is under discussion for relevance, priority, approach labels Sep 29, 2020
@dbaeumer
Copy link
Member Author

OK. Understood. May be it is enough to simply document it more

@jrieken jrieken added the polish Cleanup and polish issue label Sep 30, 2020
jrieken added a commit to microsoft/vscode-references-view that referenced this issue Sep 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
polish Cleanup and polish issue references-viewlet under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

2 participants