Git: Submodules keep appearing

[vogler]

Issue Type: Bug

I found issue #40947, deactivated git.detectSubmodules in my workspace settings, closed all submodules, but vscode still reopens them (after it gets focus?).

VS Code version: Code 1.47.2 (17299e4, 2020-07-15T18:18:50.054Z)
OS version: Darwin x64 19.6.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz (8 x 2500)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off_ok webgl: enabled webgl2: enabled
Load (avg)	2, 2, 2
Memory (System)	16.00GB (0.14GB free)
Process Argv	.
Screen Reader	no
VM	0%

Extensions (45)

Extension	Author (truncated)	Version
haskero	Van	1.3.1
Bookmarks	ale	11.3.1
vscode-sqlite	ale	0.8.2
svelte-intellisense	ard	0.7.1
spellright	ban	3.0.50
npm-intellisense	chr	1.3.0
gitignore	cod	0.6.0
githistory	don	0.6.8
xml	Dot	2.5.1
gitlens	eam	10.2.2
graphviz-preview	EFa	1.3.3
vscode-npm-script	eg2	0.3.12
vscode-great-icons	emm	2.1.47
macros	ged	1.2.1
vscode-pull-request-github	Git	0.18.0
gc-excelviewer	Gra	3.0.39
latex-workshop	Jam	8.11.1
svelte-vscode	Jam	0.9.3
hoogle-vscode	jca	0.0.7
dune	mae	0.0.5
package-json-dependencies-navigation	mam	0.1.8
Lisp	mat	0.1.10
python	ms-	2020.7.96456
remote-wsl	ms-	0.44.4
azure-account	ms-	0.8.11
cpptools	ms-	0.29.0
hexeditor	ms-	1.1.0
ocaml-platform	oca	0.8.0
vscode-code-outline	pat	0.2.1
vscode-data-preview	Ran	2.0.0
gi	rub	0.2.11
vscode-gtm	s3r	0.2.0
linter-xo	sam	2.3.3
code-settings-sync	Sha	3.4.3
vscoq	sie	0.2.7
latex-utilities	tec	0.3.7
vsfire	tob	1.4.1
stylish-haskell	vig	0.0.10
vscode-arduino	vsc	0.3.1
vscode-icons	vsc	10.2.0
vim	vsc	1.16.0
vscode-wakatime	Wak	4.0.0
quokka-vscode	Wal	1.0.310
better-align	wwm	1.1.6
material-theme	zhu	3.8.5

(3 theme extensions excluded)

[joaomoreno]

Do the submodules still appear if you restart VS Code?

[vogler]

Thanks, that fixed it. So, 'requiring a restart/not showing a message about it' is still a bug?

[vogler]

Ok, I don't know what triggered it, but now they're open again.

[joaomoreno]

@vogler Can you still repro this? Can you please provide a screen recording?

[vogler]

No, now it doesn't do it on refresh anymore but still does it on restart:

[joaomoreno]

Thanks for the screen recording. Does it also repro if you close all editor tabs?

[vogler]

Yes

[AlCalzone]

Same happens here. I have a git submodule in a directory, which keeps coming back up in the repo view. No open editor tabs.

Repro:

1. close submodule
   
2. close VSCode
3. open VSCode
4. submodule is back:
   

[abirke]

I am facing the same problem. Both options git.detectSubmodules = false and git.ignoreSubmodules = true don't seem to fix it. Unfortunately, I am not an expert on this field. Is there any way I can collect some helpful logs or try to debug into it?

Thanks and best regards
André

[wilhelmer]

Same here, would be great to see this fixed.

[duskmoon314]

Same here

1.59.0 (user setup)
379476f0e13988d90fab105c5c19e7abc8b1dea8
2021-08-04T23:13:12.822Z
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Windows_NT x64 10.0.19043

[wilhelmer]

Just found out that you can add the submodules to git.ignoredRepositories. It works now, they're gone!

[lszomoru]

Closing as duplicate of #107398